You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/10/26 12:40:54 UTC
[GitHub] [inlong] healchow commented on a diff in pull request #6299: [INLONG-6297][Manager] Refactor the PollerPlugin and SortPoller interfaces
healchow commented on code in PR #6299:
URL: https://github.com/apache/inlong/pull/6299#discussion_r1005625204
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/impl/InlongClientImpl.java:
##########
@@ -152,20 +153,22 @@ public Map<String, InlongGroupStatusInfo> listGroupStatus(List<String> groupIds)
@Override
public Map<String, InlongGroupStatusInfo> listGroupStatus(List<String> groupIds, String credentials) {
- Map<String, InlongGroupStatusInfo> statusInfoMap = listGroupStatus(groupIds);
+ Map<String, InlongGroupStatusInfo> groupStatusMap = listGroupStatus(groupIds);
// sort status info
- ListSortStatusRequest sortStatusRequest = new ListSortStatusRequest();
- sortStatusRequest.setInlongGroupIds(groupIds);
- sortStatusRequest.setCredentials(credentials);
- Map<String, SortStatus> sortStatusMap = groupClient.listSortStatus(sortStatusRequest).getStatusMap();
-
- if (MapUtils.isNotEmpty(sortStatusMap)) {
- statusInfoMap.forEach((groupId, statusInfo) -> {
- statusInfo.setSortStatus(sortStatusMap.getOrDefault(groupId, SortStatus.UNKNOWN));
- });
+ SortStatusRequest statusRequest = new SortStatusRequest();
+ statusRequest.setInlongGroupIds(groupIds);
+ statusRequest.setCredentials(credentials);
+ List<SortStatusInfo> sortStatusInfos = groupClient.listSortStatus(statusRequest);
+
+ if (CollectionUtils.isEmpty(sortStatusInfos)) {
Review Comment:
yes, my bad...
##########
inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/poller/SortStatusPoller.java:
##########
@@ -37,17 +41,38 @@
* Flink sort task status poller for inlong groups
*/
@Slf4j
-public class FlinkStatusPoller implements SortStatusPoller {
+public class SortStatusPoller implements SortPoller {
/**
- * Poll sort task status for groups
- * @param groupInfos group ids to poll
- * @param credentials not used for flink
- * @return
+ * Flink job status to InLong sort status mapping.
*/
+ private static final Map<JobStatus, SortStatus> JOB_SORT_STATUS_MAP = new HashMap<>(8);
Review Comment:
okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org