You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/01/13 10:15:00 UTC
[jira] [Work logged] (BEAM-13429) [Playground] Improve preparators by the introducing of builder
[ https://issues.apache.org/jira/browse/BEAM-13429?focusedWorklogId=708175&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-708175 ]
ASF GitHub Bot logged work on BEAM-13429:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jan/22 10:14
Start Date: 13/Jan/22 10:14
Worklog Time Spent: 10m
Work Description: daria-malkova commented on a change in pull request #16482:
URL: https://github.com/apache/beam/pull/16482#discussion_r783815142
##########
File path: playground/backend/internal/preparators/python_preparators.go
##########
@@ -27,12 +27,30 @@ const (
)
// GetPythonPreparators returns preparation methods that should be applied to Python code
-func GetPythonPreparators(filePath string) *[]Preparator {
+func GetPythonPreparators(builder *PreparersBuilder) {
Review comment:
Done
##########
File path: playground/backend/internal/utils/preparators_utils.go
##########
@@ -18,24 +18,34 @@ package utils
import (
pb "beam.apache.org/playground/backend/internal/api/v1"
"beam.apache.org/playground/backend/internal/preparators"
+ "beam.apache.org/playground/backend/internal/validators"
"fmt"
"regexp"
+ "sync"
)
// GetPreparators returns slice of preparators.Preparator according to sdk
-func GetPreparators(sdk pb.Sdk, filepath string) (*[]preparators.Preparator, error) {
- var prep *[]preparators.Preparator
+func GetPreparators(sdk pb.Sdk, filepath string, valResults *sync.Map) (*[]preparators.Preparator, error) {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 708175)
Time Spent: 0.5h (was: 20m)
> [Playground] Improve preparators by the introducing of builder
> ---------------------------------------------------------------
>
> Key: BEAM-13429
> URL: https://issues.apache.org/jira/browse/BEAM-13429
> Project: Beam
> Issue Type: Improvement
> Components: beam-playground
> Reporter: Daria Malkova
> Assignee: Daria Malkova
> Priority: P3
> Labels: beam-playground-backend, beam-playground-sprint-6, beam-playground-sprint-7
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Investigate and implement (if need) a usage of a builder for preparators to construct the necessary builders for each SDK/unit-test/not-unit-test
--
This message was sent by Atlassian Jira
(v8.20.1#820001)