[GitHub] [couchdb] nickva commented on pull request #4604: Optimize mem3:dbname/1 function

["nickva (via GitHub)" <gi...@apache.org>]

nickva commented on PR #4604:
URL: https://github.com/apache/couchdb/pull/4604#issuecomment-1552073263

   > @nickva do we need to handle Windows path separators here as well?
   
   Good point, @willholley. I had noticed in other parts of the code we don't handle Windows paths as just use `/` and expect Windows to handle that format as well. Since I had updated the PR to do a simpler check like and fall back to the previous method if that fails.
   
   > I would suggest to place this function in couch_util.
   
   @iilyak I started doing it that way but then in the latest version, opted to just specialize the function to handle timestamp specifically, so then mem3 seemed like a good place for it. If those other places are hotspots seen in profiling we can optimize those too if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org