You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/11/04 12:05:12 UTC

[GitHub] [couchdb] iilyak edited a comment on issue #2286: Opentracing

iilyak edited a comment on issue #2286: Opentracing
URL: https://github.com/apache/couchdb/pull/2286#issuecomment-549324633
 
 
   > I thought about adding one more by_operation(operation).
   
   Another idea I had is to use generated matching module instead of  `chttpd_handlers:handler_info(Req)`. This would allow as to have action names configurable. It might look as follows:
   ```
   [httpd.actions]
   
   all_dbs_read = (#{path_parts := [<<"_all_dbs">>], method := 'GET'}) -> {'all-dbs.read', [tag1, tag2]}
   bulk = (#{path_parts := [<<"_bulk">>], method := 'GET'}) -> {chttpd_operations, operation, [extra_args]}
   ```
   
   
   However it makes things more complex and doesn't solve our problem of knowing operation id when we call start_span. Also we would have to make DSL parser less restrictive to allow direct matching of values in the parameters (since we need to support complex types (in this case list of binaries)).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services