You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/03/19 11:01:30 UTC

[GitHub] andrzej-kaczmarek commented on a change in pull request #7: Enable statistic for NFFS

andrzej-kaczmarek commented on a change in pull request #7: Enable statistic for NFFS
URL: https://github.com/apache/mynewt-nffs/pull/7#discussion_r175396310
 
 

 ##########
 File path: include/nffs/nffs.h
 ##########
 @@ -284,6 +289,29 @@ struct nffs_dir {
     struct nffs_dirent nd_dirent;
 };
 
+STATS_SECT_START(nffs_stats)
 
 Review comment:
   this will now compile only on Zephyr
   
   I'd either wrap everything in `#ifdef STATS_SECT_START` or create empty macros for non-Zephyr builds like we have for `STATS_INC` now. For Mynewt build (once it's finally changed to use this repo) we'll just add proper headers above later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services