[GitHub] [pinot] npawar commented on a diff in pull request #8606: Add unrecognizedProperties to schema and tableConfigs APIs

[GitBox <gi...@apache.org>]

npawar commented on code in PR #8606:
URL: https://github.com/apache/pinot/pull/8606#discussion_r862250198


##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/StringUtil.java:
##########
@@ -53,4 +57,22 @@ public static String sanitizeStringValue(String value, int maxLength) {
     }
     return value.substring(0, Math.min(index, maxLength));
   }
+
+  /**
+   * InputStream object to String
+   * @param inputStream InputStream to be converted
+   * @return String holding the contents of the inputStream
+   * @throws IOException
+   */
+  public static String inputStreamToString(InputStream inputStream)

Review Comment:
   curious why you chose to add this vs using the short IOUtils.toString(InputStream, CharSet) method?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org