You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by Sandeep Nayak <os...@gmail.com> on 2014/04/22 22:26:16 UTC

API rework update

Hi guys,

Last night I checked in another round of API rework. Highlights are

- Commands added for items other than cluster
- Command builders for the above commands
- Rebalancer package - there is more to be done here, this is work in
progress
- Started SPI project
- Started example based on the new API in examples project

I need to do another pass on the code and figure if I can tighten some of
the loose corners but wanted to allow review in parallel so all current
work is checked in. Please review and provide feedback. I will send an
update if I make more changes.

Thanks,

Sandeep

Re: API rework update

Posted by Sandeep Nayak <os...@gmail.com>.

Thanks for the thorough feedback Kanak, I will go through them and
incorporate as appropriate.

One thing I am considering is to make the command builders more
simpler an example of that simplicity is to allow the user to create a
cluster command using string value for cluster id rather than having
to create ClusterId object. The builder can do that internally for the
user. Such simplifications will just add value to using the builder
route i.e. coerce the user to leverage builders IMO.

Thanks,

Sandeep

On Tue, Apr 22, 2014 at 3:07 PM, Kanak Biscuitwala <ka...@hotmail.com> wrote:
>
> Great work so far. I have commented inline on each of your recent commits.
>
> Kanak
> ----------------------------------------
>> Date: Tue, 22 Apr 2014 13:26:16 -0700
>> Subject: API rework update
>> From: osgigeek@gmail.com
>> To: dev@helix.apache.org
>>
>> Hi guys,
>>
>> Last night I checked in another round of API rework. Highlights are
>>
>> - Commands added for items other than cluster
>> - Command builders for the above commands
>> - Rebalancer package - there is more to be done here, this is work in
>> progress
>> - Started SPI project
>> - Started example based on the new API in examples project
>>
>> I need to do another pass on the code and figure if I can tighten some of
>> the loose corners but wanted to allow review in parallel so all current
>> work is checked in. Please review and provide feedback. I will send an
>> update if I make more changes.
>>
>> Thanks,
>>
>> Sandeep
>

RE: API rework update

Posted by Kanak Biscuitwala <ka...@hotmail.com>.

Great work so far. I have commented inline on each of your recent commits.

Kanak
----------------------------------------
> Date: Tue, 22 Apr 2014 13:26:16 -0700
> Subject: API rework update
> From: osgigeek@gmail.com
> To: dev@helix.apache.org
>
> Hi guys,
>
> Last night I checked in another round of API rework. Highlights are
>
> - Commands added for items other than cluster
> - Command builders for the above commands
> - Rebalancer package - there is more to be done here, this is work in
> progress
> - Started SPI project
> - Started example based on the new API in examples project
>
> I need to do another pass on the code and figure if I can tighten some of
> the loose corners but wanted to allow review in parallel so all current
> work is checked in. Please review and provide feedback. I will send an
> update if I make more changes.
>
> Thanks,
>
> Sandeep