You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <mo...@yahoo.in> on 2013/09/06 02:58:37 UTC

Review Request 14006: [GUI] OOZIE-1509 Do not preload all tabs in Oozie UI and make Active Jobs default

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14006/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1509
    https://issues.apache.org/jira/browse/OOZIE-1509


Repository: oozie


Description
-------

See JIRA Description


Diffs
-----

  trunk/webapp/src/main/webapp/oozie-console.js 1520462 

Diff: https://reviews.apache.org/r/14006/diff/


Testing
-------

Manual testing done


Thanks,

Mona Chitnis


Re: Review Request 14006: [GUI] OOZIE-1509 Do not preload all tabs in Oozie UI and make Active Jobs default

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14006/#review25972
-----------------------------------------------------------


Since we are changing the default to Active Jobs, can we have the selected one highlighted. Currently what is selected is not highlighted.


trunk/webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/14006/#comment50678>

    Should not reload for every tabchange. Only the first time


- Rohini Palaniswamy


On Sept. 6, 2013, 12:58 a.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14006/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 12:58 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1509
>     https://issues.apache.org/jira/browse/OOZIE-1509
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> See JIRA Description
> 
> 
> Diffs
> -----
> 
>   trunk/webapp/src/main/webapp/oozie-console.js 1520462 
> 
> Diff: https://reviews.apache.org/r/14006/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>


Re: Review Request 14006: [GUI] OOZIE-1509 Do not preload all tabs in Oozie UI and make Active Jobs default

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14006/#review25976
-----------------------------------------------------------

Ship it!


Ship It!

- Rohini Palaniswamy


On Sept. 7, 2013, 1:49 a.m., Mona Chitnis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14006/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2013, 1:49 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1509
>     https://issues.apache.org/jira/browse/OOZIE-1509
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> See JIRA Description
> 
> 
> Diffs
> -----
> 
>   trunk/webapp/src/main/webapp/index.jsp 1520462 
>   trunk/webapp/src/main/webapp/oozie-console.css PRE-CREATION 
>   trunk/webapp/src/main/webapp/oozie-console.js 1520462 
> 
> Diff: https://reviews.apache.org/r/14006/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Mona Chitnis
> 
>


Re: Review Request 14006: [GUI] OOZIE-1509 Do not preload all tabs in Oozie UI and make Active Jobs default

Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14006/
-----------------------------------------------------------

(Updated Sept. 7, 2013, 1:49 a.m.)


Review request for oozie.


Changes
-------

- Addressed review comments
- Added CSS file to be referenced for the All/Active/Done Jobs selection
- added Custom Filter button for Bundle Jobs tab too


Bugs: OOZIE-1509
    https://issues.apache.org/jira/browse/OOZIE-1509


Repository: oozie


Description
-------

See JIRA Description


Diffs (updated)
-----

  trunk/webapp/src/main/webapp/index.jsp 1520462 
  trunk/webapp/src/main/webapp/oozie-console.css PRE-CREATION 
  trunk/webapp/src/main/webapp/oozie-console.js 1520462 

Diff: https://reviews.apache.org/r/14006/diff/


Testing
-------

Manual testing done


Thanks,

Mona Chitnis