You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2018/04/11 22:13:03 UTC

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66186/
-----------------------------------------------------------

(Updated April 12, 2018, 12:13 a.m.)


Review request for Aurora, Reza Motamedi and Santhosh Kumar Shanmugham.


Repository: aurora


Description
-------

The changelog claims: `Process.children() is 2x faster on UNIX and 2.4x faster on Linux.`

This is needed for all stats retrieved via `ProcessTreeCollector`. An update therefore
seems worthwhile. 

https://github.com/giampaolo/psutil/blob/master/HISTORY.rst


Diffs
-----

  3rdparty/python/requirements.txt 4ac242cfa2c1c19cb7447816ab86e748839d3d11 
  src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py 93ff878be578fa7a63d25b65e7d915790dc9ccc6 


Diff: https://reviews.apache.org/r/66186/diff/1/


Testing (updated)
-------

Successfully verified in vagrant that CPU and memory are reported as expected.


Thanks,

Stephan Erb

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66186/#review201337
-----------------------------------------------------------


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On April 11, 2018, 3:13 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66186/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 3:13 p.m.)
> 
> 
> Review request for Aurora, Reza Motamedi and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The changelog claims: `Process.children() is 2x faster on UNIX and 2.4x faster on Linux.`
> 
> This is needed for all stats retrieved via `ProcessTreeCollector`. An update therefore
> seems worthwhile. 
> 
> https://github.com/giampaolo/psutil/blob/master/HISTORY.rst
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 4ac242cfa2c1c19cb7447816ab86e748839d3d11 
>   src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py 93ff878be578fa7a63d25b65e7d915790dc9ccc6 
> 
> 
> Diff: https://reviews.apache.org/r/66186/diff/1/
> 
> 
> Testing
> -------
> 
> Successfully verified in vagrant that CPU and memory are reported as expected.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

Posted by Stephan Erb <se...@apache.org>.


> On April 12, 2018, 1:31 a.m., Reza Motamedi wrote:
> > Did you notice any real performance improvements?

No, not really :-/. But I guess that updating still does not harm.


- Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66186/#review200944
-----------------------------------------------------------


On April 12, 2018, 12:13 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66186/
> -----------------------------------------------------------
> 
> (Updated April 12, 2018, 12:13 a.m.)
> 
> 
> Review request for Aurora, Reza Motamedi and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The changelog claims: `Process.children() is 2x faster on UNIX and 2.4x faster on Linux.`
> 
> This is needed for all stats retrieved via `ProcessTreeCollector`. An update therefore
> seems worthwhile. 
> 
> https://github.com/giampaolo/psutil/blob/master/HISTORY.rst
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 4ac242cfa2c1c19cb7447816ab86e748839d3d11 
>   src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py 93ff878be578fa7a63d25b65e7d915790dc9ccc6 
> 
> 
> Diff: https://reviews.apache.org/r/66186/diff/1/
> 
> 
> Testing
> -------
> 
> Successfully verified in vagrant that CPU and memory are reported as expected.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

Posted by Reza Motamedi <re...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66186/#review200944
-----------------------------------------------------------


Ship it!




Did you notice any real performance improvements?

- Reza Motamedi


On April 11, 2018, 10:13 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66186/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 10:13 p.m.)
> 
> 
> Review request for Aurora, Reza Motamedi and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The changelog claims: `Process.children() is 2x faster on UNIX and 2.4x faster on Linux.`
> 
> This is needed for all stats retrieved via `ProcessTreeCollector`. An update therefore
> seems worthwhile. 
> 
> https://github.com/giampaolo/psutil/blob/master/HISTORY.rst
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 4ac242cfa2c1c19cb7447816ab86e748839d3d11 
>   src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py 93ff878be578fa7a63d25b65e7d915790dc9ccc6 
> 
> 
> Diff: https://reviews.apache.org/r/66186/diff/1/
> 
> 
> Testing
> -------
> 
> Successfully verified in vagrant that CPU and memory are reported as expected.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

Posted by Renan DelValle <re...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66186/#review201278
-----------------------------------------------------------


Ship it!




Ship It!

- Renan DelValle


On April 11, 2018, 3:13 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66186/
> -----------------------------------------------------------
> 
> (Updated April 11, 2018, 3:13 p.m.)
> 
> 
> Review request for Aurora, Reza Motamedi and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The changelog claims: `Process.children() is 2x faster on UNIX and 2.4x faster on Linux.`
> 
> This is needed for all stats retrieved via `ProcessTreeCollector`. An update therefore
> seems worthwhile. 
> 
> https://github.com/giampaolo/psutil/blob/master/HISTORY.rst
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 4ac242cfa2c1c19cb7447816ab86e748839d3d11 
>   src/test/python/apache/thermos/monitoring/test_process_collector_psutil.py 93ff878be578fa7a63d25b65e7d915790dc9ccc6 
> 
> 
> Diff: https://reviews.apache.org/r/66186/diff/1/
> 
> 
> Testing
> -------
> 
> Successfully verified in vagrant that CPU and memory are reported as expected.
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>