[GitHub] spark issue #16603: [SPARK-19244][Core] Sort MemoryConsumers according to th...

[viirya <gi...@git.apache.org>]

Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/16603
  
    @vazin Thanks for the review.
    
    For "fast fail", looks like we don't check if we obtain enough memory after spilling all consumers including itself. The consumer which asks more memory will decide it fails or not after this memory acquirement, based on the memory it gets. I think more proper error message is thrown in individual consumer impl. now. So I'd prefer not to add it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org