You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2021/03/04 23:31:50 UTC
[GitHub] [tomcat] mcroteau opened a new pull request #410: Apologies if disrespectful...
mcroteau opened a new pull request #410:
URL: https://github.com/apache/tomcat/pull/410
.war extensions I believe may turn some people off so I refactored much of the deployment routines to accept additional extensions. Much of the heavy lifting is finished but needs additional testing. Thank you for all that you provide, I have been using Tomcat for 12 years now. I am truly grateful.
Please let me know if you would like me to proceed. There is a small issue with the Manager app that I needs to be addressed. The ManagerServlet keeps the original extension and adds .war.
Thank you.
Mike
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #410: Thank you! Apologies if unable to use right now...
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #410:
URL: https://github.com/apache/tomcat/pull/410#issuecomment-791034688
I understand where you are coming from with this PR but you can't break backwards compatibility the way this PR does. It also breaks things as can be seen from the CI checks.
Bundle has its own meaning in this space - see OSGi - and I think using it in this context will cause user confusion.
This is a very big change. Too big, I would suggest, for a single PR.
My suggestion would be to close this PR and look at the user visible uses of "war" - at least as a starting point - as far more people will see those than the internal code. While I don't think it will be possible to remove every reference right away, I am sure there are places where web archive could be used instead. I suggest starting small, maybe with a single documentation page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #410: Thank you! Apologies if unable to use right now...
Posted by GitBox <gi...@apache.org>.
markt-asf commented on pull request #410:
URL: https://github.com/apache/tomcat/pull/410#issuecomment-800067871
Closing as per my previous suggestion.
To repeat what I said previously:
> My suggestion would be ... look at the user visible uses of "war" - at least as a starting point - as far more people will see those than the internal code. While I don't think it will be possible to remove every reference right away, I am sure there are places where web archive could be used instead. I suggest starting small, maybe with a single documentation page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] mcroteau commented on pull request #410: Thank you! Apologies if unable to use right now...
Posted by GitBox <gi...@apache.org>.
mcroteau commented on pull request #410:
URL: https://github.com/apache/tomcat/pull/410#issuecomment-791045036
So I take it as a "no" to continue? The java source is pretty much covered. I went line by line and replaced with Bundle/bundle and will do the same for test if you would like.
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #410: Thank you! Apologies if unable to use right now...
Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #410:
URL: https://github.com/apache/tomcat/pull/410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] mcroteau commented on pull request #410: Thank you! Apologies if unable to use right now...
Posted by GitBox <gi...@apache.org>.
mcroteau commented on pull request #410:
URL: https://github.com/apache/tomcat/pull/410#issuecomment-800286751
I’m sorry.
On Tue, Mar 16, 2021 at 12:40 AM Mark Thomas ***@***.***>
wrote:
> Closing as per my previous suggestion.
>
> To repeat what I said previously:
>
> My suggestion would be ... look at the user visible uses of "war" - at
> least as a starting point - as far more people will see those than the
> internal code. While I don't think it will be possible to remove every
> reference right away, I am sure there are places where web archive could be
> used instead. I suggest starting small, maybe with a single documentation
> page.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tomcat/pull/410#issuecomment-800067871>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAVASNDWRNIPZZZE6J7MC3TD4KQFANCNFSM4YUFVS4Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org