[GitHub] [zeppelin] zjffdu commented on pull request #4332: [ZEPPELIN-5668] Support statement set in flink

[GitBox <gi...@apache.org>]

zjffdu commented on pull request #4332:
URL: https://github.com/apache/zeppelin/pull/4332#issuecomment-1082514236


   > LGTM but I have an opinion. First of all, I'm not an expert on Flink so you can freely tell me where I might misunderstand it. I saw the `Flink113SqlInterpreter` and felt like `statementModeMap` is acting like a pair of `statementOperationMap`. I think we can change the logic like check if `statementOperationMap.get(context.getParagraphId()) == null` or not. If it's null, it look same as `statementModeMap.get(context.getParagraphId()) == false`. If it's true, we'd better remove `statementModeMap` and add logic to check nullability of `statmentOperationsMap.get(...) == null`. Am I correct? :-)
   > 
   > Regardless of the opinion above, It looks good to me :-)
   
   You are right @jongyoul  I have updated it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org