You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/06/22 11:01:43 UTC
[GitHub] [tinkerpop] nikita15p opened a new pull request, #1732: fixed null exception
nikita15p opened a new pull request, #1732:
URL: https://github.com/apache/tinkerpop/pull/1732
Signed-off-by: nikita15p <ni...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] divijvaidya commented on pull request #1732: fixed null exception
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #1732:
URL: https://github.com/apache/tinkerpop/pull/1732#issuecomment-1163342876
Thank you for the code change @nikita15p. Could we add a unit test here which fails prior to this change and passes after? It would help us catch any regression in future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] lyndonbauto commented on pull request #1732: fixed null exception
Posted by GitBox <gi...@apache.org>.
lyndonbauto commented on PR #1732:
URL: https://github.com/apache/tinkerpop/pull/1732#issuecomment-1218546764
@nikita15p bump - are you able to make a unit test for this situation? Would be good to know how this is happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] nikita15p commented on pull request #1732: fixed null exception
Posted by GitBox <gi...@apache.org>.
nikita15p commented on PR #1732:
URL: https://github.com/apache/tinkerpop/pull/1732#issuecomment-1218910306
I faced this problem in my code and have fixed it locally. Will write a UT
and update the PR. Couldn't work on this till now.
Thanks and Regards,
Nikita
On Thu, 18 Aug, 2022, 3:47 am Lyndon Bauto, ***@***.***>
wrote:
> @nikita15p <https://github.com/nikita15p> bump - are you able to make a
> unit test for this situation? Would be good to know how this is happening.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tinkerpop/pull/1732#issuecomment-1218546764>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AI7JTNHQWHAETV6OOAPT7R3VZVQGZANCNFSM5ZPZJ4SQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] nikita15p commented on pull request #1732: fixed null exception
Posted by GitBox <gi...@apache.org>.
nikita15p commented on PR #1732:
URL: https://github.com/apache/tinkerpop/pull/1732#issuecomment-1197981171
@divijvaidya
Same condition `currentPath != null` is already available at line 408, since we are accessing objects() method.
Is there any test case for that? Basically this is the obvious fix which I am recommending since I came across exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy commented on pull request #1732: fixed null exception
Posted by GitBox <gi...@apache.org>.
xiazcy commented on PR #1732:
URL: https://github.com/apache/tinkerpop/pull/1732#issuecomment-1324337297
Thank you for raising the PR. We've decided to close this one as there has not been any activity in the past 3 months.
Please feel free to open another PR to fix this if you are still interested, providing an explanation on how the current path leads to the exception and adding a unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] xiazcy closed pull request #1732: fixed null exception
Posted by GitBox <gi...@apache.org>.
xiazcy closed pull request #1732: fixed null exception
URL: https://github.com/apache/tinkerpop/pull/1732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1732: fixed null exception
Posted by GitBox <gi...@apache.org>.
spmallette commented on PR #1732:
URL: https://github.com/apache/tinkerpop/pull/1732#issuecomment-1198034364
i think the check at 408 is part of the design for `extendPath()` where `null` is expected. i think @divijvaidya is questioning the circumstances around the `currentPath` being `null` in `processEdges()` where it doesn't seem clear how `currentPath` would end up that way. understanding "how" would better explain what is happening there and if simply ignoring the subsequent code path is the right fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1732: fixed null exception
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1732:
URL: https://github.com/apache/tinkerpop/pull/1732#issuecomment-1162966726
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1732?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1732](https://codecov.io/gh/apache/tinkerpop/pull/1732?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (10b463d) into [master](https://codecov.io/gh/apache/tinkerpop/commit/5438925e6be3ec8df7e04a2fd232fda018232fe3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5438925) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1732 +/- ##
=======================================
Coverage 63.84% 63.84%
=======================================
Files 23 23
Lines 3596 3596
=======================================
Hits 2296 2296
Misses 1137 1137
Partials 163 163
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1732?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1732?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5438925...10b463d](https://codecov.io/gh/apache/tinkerpop/pull/1732?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org