Message for commit on behalf of someone should be informative

[Pinaki Poddar <pp...@apache.org>]

Hi,
  I notice commit comments like this
  "OPENJPA-NNN: Commiting patch contributed by XXX YYY"

  Now this message is not helpful in retrospect. The message should be
  "OPENJPA-NNN: Change for this or that. Committing on behalf of XXX YYY."


-----
Pinaki 
-- 
View this message in context: http://n2.nabble.com/Message-for-commit-on-behalf-of-someone-should-be-informative-tp3195839p3195839.html
Sent from the OpenJPA Developers mailing list archive at Nabble.com.

Re: Message for commit on behalf of someone should be informative

[Donald Woods <dw...@apache.org>]

Here are the ASF suggested guidelines -

http://www.apache.org/dev/committers.html#applying-patches

"You need to make sure that the commit message contains at least the 
name of the contributor and ideally a reference to the Bugzilla or JIRA 
issue where the patch was submitted. The reasons: this preserves the 
legal trail and makes sure that contributors are recognized. Obviously, 
the latter doesn't mean it's not a good idea to list the names of all 
contributors somewhere on the website. To make it easier to "grep" for 
commits with patches from contributors, always use the same pattern in 
the commit message. Traditionally, we use "Submitted by: <name>" or 
"Obtained from: <name>"."


Personally, I like to use the "contributed by" text, but don't care what 
format people use, as long as the contributors name is included.


-Donald


Personally, I don't care as long as

Pinaki Poddar wrote:
> Hi,
>   I notice commit comments like this
>   "OPENJPA-NNN: Commiting patch contributed by XXX YYY"
> 
>   Now this message is not helpful in retrospect. The message should be
>   "OPENJPA-NNN: Change for this or that. Committing on behalf of XXX YYY."
> 
> 
> -----
> Pinaki