You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2015/02/19 10:05:00 UTC
Review Request 31180: CLOUDSTACK-8269: Code changes in primary
storage test cases as per recent change in product behavior
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31180/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8269
https://issues.apache.org/jira/browse/CLOUDSTACK-8269
Repository: cloudstack-git
Description
-------
1. Earlier volume would get deleted when vm is deleted, now the volume does not get deleted and it remains in detached state unless account is removed. This volume gets counted in primary storage count of the account.
2. Earlier when volume was detached from VM, the primary storage count of the account would get reduced by the volume size. Now the primary storage count does not get reduced unless the volume is deleted.
The patch contains appropriate changes in the test cases as per changed behavior in product as stated above.
Diffs
-----
test/integration/component/test_ps_domain_limits.py d9c1018
test/integration/component/test_ps_limits.py c9a754b
Diff: https://reviews.apache.org/r/31180/diff/
Testing
-------
Test primary storage limit of domain and its sub-domains ... === TestName: test_01_multiple_domains_primary_storage_limits | Status :
SUCCESS ===
ok
Test primary storage counts in multiple child domains ... === TestName: test_02_multiple_domains_primary_storage_limits | Status :
SUCCESS ===
ok
Test primary storage counts in multiple child domains ... === TestName: test_03_multiple_domains_multiple_volumes | Status : SUCCESS ===
ok
Test create snapshot and templates from volume ... === TestName: test_04_create_template_snapshot | Status : SUCCESS ===
ok
Test assign virtual machine to account belonging to different domain ... === TestName: test_05_assign_virtual_machine_different_domain
| Status : SUCCESS ===
ok
Test primary storage counts while destroying and recovering VM ... === TestName: test_06_destroy_recover_vm | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 6 tests in 1619.606s
OK
Test Deploy multiple VMs with & verify the usage ... === TestName: test_deploy_multiple_vm_1_root_domain_admin | Status : SUCCESS ===
ok
Test Deploy multiple VMs with & verify the usage ... === TestName: test_deploy_multiple_vm_2_child_domain_admin | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 399.904s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 31180: CLOUDSTACK-8269: Code changes in primary
storage test cases as per recent change in product behavior
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31180/#review73274
-----------------------------------------------------------
Ship it!
53bae00801235c104f73a56501ff417209154546 master
- SrikanteswaraRao Talluri
On Feb. 19, 2015, 9:05 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31180/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2015, 9:05 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8269
> https://issues.apache.org/jira/browse/CLOUDSTACK-8269
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Earlier volume would get deleted when vm is deleted, now the volume does not get deleted and it remains in detached state unless account is removed. This volume gets counted in primary storage count of the account.
>
> 2. Earlier when volume was detached from VM, the primary storage count of the account would get reduced by the volume size. Now the primary storage count does not get reduced unless the volume is deleted.
>
> The patch contains appropriate changes in the test cases as per changed behavior in product as stated above.
>
>
> Diffs
> -----
>
> test/integration/component/test_ps_domain_limits.py d9c1018
> test/integration/component/test_ps_limits.py c9a754b
>
> Diff: https://reviews.apache.org/r/31180/diff/
>
>
> Testing
> -------
>
> Test primary storage limit of domain and its sub-domains ... === TestName: test_01_multiple_domains_primary_storage_limits | Status :
> SUCCESS ===
> ok
> Test primary storage counts in multiple child domains ... === TestName: test_02_multiple_domains_primary_storage_limits | Status :
> SUCCESS ===
> ok
> Test primary storage counts in multiple child domains ... === TestName: test_03_multiple_domains_multiple_volumes | Status : SUCCESS ===
> ok
> Test create snapshot and templates from volume ... === TestName: test_04_create_template_snapshot | Status : SUCCESS ===
> ok
> Test assign virtual machine to account belonging to different domain ... === TestName: test_05_assign_virtual_machine_different_domain
> | Status : SUCCESS ===
> ok
> Test primary storage counts while destroying and recovering VM ... === TestName: test_06_destroy_recover_vm | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 6 tests in 1619.606s
>
> OK
>
>
> Test Deploy multiple VMs with & verify the usage ... === TestName: test_deploy_multiple_vm_1_root_domain_admin | Status : SUCCESS ===
> ok
> Test Deploy multiple VMs with & verify the usage ... === TestName: test_deploy_multiple_vm_2_child_domain_admin | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 2 tests in 399.904s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>