You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by AnthonyTruchet <gi...@git.apache.org> on 2016/11/18 10:19:46 UTC
[GitHub] spark pull request #15931: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...
GitHub user AnthonyTruchet opened a pull request:
https://github.com/apache/spark/pull/15931
[SPARK-18471][MLLIB] In LBFGS, avoid sending huge vectors of 0
## What changes were proposed in this pull request?
The zero for the aggregation used to be shipped into a closure which is
higly problematic when this zero is big (100s of MB is typical for ML).
This change introduces a new overload of treeAggregate which only ships a
function able to generate this zero.
## How was this patch tested?
Unit tests for core module launched locally
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AnthonyTruchet/spark ENG-17719-lbfgs-only
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15931.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15931
----
commit d5d110b8fc0d7165cce116c1e8342ce7aca2467b
Author: Eugene Kharitonov <e....@criteo.com>
Date: 2016-10-14T11:25:34Z
[SPARK-18471][MLLIB] In LBFGS, avoid sending huge vectors of 0
CostFun used to send a dense vector of zeroes as a closure in a
treeAggregate call. To avoid that, we replace treeAggregate by
mapPartition + treeReduce, creating a zero vector inside the mapPartition
block in-place.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15931: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15931
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15931: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15931
See my comments from your previous PR; they still apply. https://github.com/apache/spark/pull/15905
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15931: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge vector...
Posted by AnthonyTruchet <gi...@git.apache.org>.
Github user AnthonyTruchet commented on the issue:
https://github.com/apache/spark/pull/15931
Sure, sorry I mistakenly pushed a badly rebased version
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15931: [SPARK-18471][MLLIB] In LBFGS, avoid sending huge...
Posted by AnthonyTruchet <gi...@git.apache.org>.
Github user AnthonyTruchet closed the pull request at:
https://github.com/apache/spark/pull/15931
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org