You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/03 15:57:03 UTC
[GitHub] [shardingsphere] codecov-io commented on pull request #5419: Use SPI to build rule from configuration
codecov-io commented on pull request #5419:
URL: https://github.com/apache/shardingsphere/pull/5419#issuecomment-623131172
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5419?src=pr&el=h1) Report
> Merging [#5419](https://codecov.io/gh/apache/shardingsphere/pull/5419?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/079a87912d2ba1898cd71ab16a7b6fae519128a4&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `25.00%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/5419?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5419 +/- ##
============================================
- Coverage 53.85% 53.83% -0.02%
Complexity 419 419
============================================
Files 1162 1165 +3
Lines 20866 20873 +7
Branches 3773 3769 -4
============================================
Hits 11238 11238
- Misses 8912 8919 +7
Partials 716 716
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5419?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...sphere/encrypt/metadata/EncryptMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvbWV0YWRhdGEvRW5jcnlwdE1ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...hardingsphere/encrypt/rule/EncryptRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree#diff-ZW5jcnlwdC1jb3JlL2VuY3J5cHQtY29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcnVsZS9FbmNyeXB0UnVsZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...phere/core/metadata/ShardingMetaDataDecorator.java](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ01ldGFEYXRhRGVjb3JhdG9yLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ngsphere/core/metadata/ShardingMetaDataLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9tZXRhZGF0YS9TaGFyZGluZ01ldGFEYXRhTG9hZGVyLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...ardingsphere/core/rule/MasterSlaveRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL01hc3RlclNsYXZlUnVsZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/shardingsphere/core/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZS5qYXZh) | `72.91% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../shardingsphere/core/rule/ShardingRuleBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1NoYXJkaW5nUnVsZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...org/apache/shardingsphere/core/rule/TableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvY29yZS9ydWxlL1RhYmxlUnVsZS5qYXZh) | `88.88% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...rator/impl/ShardingInsertValuesTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vZ2VuZXJhdG9yL2ltcGwvU2hhcmRpbmdJbnNlcnRWYWx1ZXNUb2tlbkdlbmVyYXRvci5qYXZh) | `86.95% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...arding/rewrite/token/pojo/ShardingInsertValue.java](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3Jld3JpdGUvdG9rZW4vcG9qby9TaGFyZGluZ0luc2VydFZhbHVlLmphdmE=) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| ... and [22 more](https://codecov.io/gh/apache/shardingsphere/pull/5419/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5419?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5419?src=pr&el=footer). Last update [079a879...b15ef2f](https://codecov.io/gh/apache/shardingsphere/pull/5419?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org