You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/23 16:06:53 UTC
[GitHub] [camel] Steve973 opened a new pull request #6810: CAMEL-17500: Simplified Dynamic Router control channel messages.
Steve973 opened a new pull request #6810:
URL: https://github.com/apache/camel/pull/6810
This pull requests provides simplification to the Dynamic Router EIP component with regard to control channel messages. Instead of only having the option to create and send a POJO for all of the parameters of subscribing or unsubscribing, this pull request allows a user to:
- use the URI for all parameters, or to use a combination of URI parameters and a bean in the registry that contains the exchange filtering predicate
- use a combination of URI parameters and a Predicate as the message body to use as the exchange filtering predicate
- omit the subscription ID URI parameter to have the subscription ID generated as a UUID string and returned as the message body
A pull request will follow this one, in the near future for:
- an update to the corresponding Spring Boot starter
- an update to the corresponding Spring Boot example
<!-- Uncomment and fill this section if your PR is not trivial
- [x] [JIRA issue](https://issues.apache.org/jira/browse/CAMEL-17500)
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Steve973 removed a comment on pull request #6810: Draft: CAMEL-17500: Simplified Dynamic Router control channel messages.
Posted by GitBox <gi...@apache.org>.
Steve973 removed a comment on pull request #6810:
URL: https://github.com/apache/camel/pull/6810#issuecomment-1019525020
Hi, @davsclaus and @zregvart I did not get this same error when running the exact same command on my machine.
`mvn -V -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 --no-transfer-progress -Dcheckstyle.failOnViolation=true checkstyle:checkstyle`
It is also in a different module, so do you have any idea what might be causing the checkstyle violation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Steve973 commented on pull request #6810: CAMEL-17500: Simplified Dynamic Router control channel messages.
Posted by GitBox <gi...@apache.org>.
Steve973 commented on pull request #6810:
URL: https://github.com/apache/camel/pull/6810#issuecomment-1019525020
Hi, @davsclaus and @zregvart I did not get this same error when running the exact same command on my machine. It is also in a different module, so do you have any idea what might be causing the checkstyle violation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Steve973 commented on pull request #6810: CAMEL-17500: Simplified Dynamic Router control channel messages.
Posted by GitBox <gi...@apache.org>.
Steve973 commented on pull request #6810:
URL: https://github.com/apache/camel/pull/6810#issuecomment-1022743556
@davsclaus and @oscerd If you guys still approve, it should be ok to merge this now, and if the performance can be improved for the mode that matches all recipients, then we can do that in a follow-up pull request, if you both agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus edited a comment on pull request #6810: Draft: CAMEL-17500: Simplified Dynamic Router control channel messages.
Posted by GitBox <gi...@apache.org>.
davsclaus edited a comment on pull request #6810:
URL: https://github.com/apache/camel/pull/6810#issuecomment-1020037735
You can make a PR as "draft", by clicking the drop down arrow on the green button, and there is a "convert to draft" or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #6810: CAMEL-17500: Simplified Dynamic Router control channel messages.
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #6810:
URL: https://github.com/apache/camel/pull/6810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Steve973 edited a comment on pull request #6810: CAMEL-17500: Simplified Dynamic Router control channel messages.
Posted by GitBox <gi...@apache.org>.
Steve973 edited a comment on pull request #6810:
URL: https://github.com/apache/camel/pull/6810#issuecomment-1019525020
Hi, @davsclaus and @zregvart I did not get this same error when running the exact same command on my machine.
`mvn -V -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120 --no-transfer-progress -Dcheckstyle.failOnViolation=true checkstyle:checkstyle`
It is also in a different module, so do you have any idea what might be causing the checkstyle violation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Steve973 commented on pull request #6810: Draft: CAMEL-17500: Simplified Dynamic Router control channel messages.
Posted by GitBox <gi...@apache.org>.
Steve973 commented on pull request #6810:
URL: https://github.com/apache/camel/pull/6810#issuecomment-1020026840
@davsclaus and @oscerd please don't merge this yet. I have questions about parallel processing of exchanges. Merging this in will result in a broken dynamic router component (which is why it's marked as draft). I posted to the mailing list, for whenever you might have some time. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #6810: Draft: CAMEL-17500: Simplified Dynamic Router control channel messages.
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #6810:
URL: https://github.com/apache/camel/pull/6810#issuecomment-1020037735
You can make a PR as "draft"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus edited a comment on pull request #6810: Draft: CAMEL-17500: Simplified Dynamic Router control channel messages.
Posted by GitBox <gi...@apache.org>.
davsclaus edited a comment on pull request #6810:
URL: https://github.com/apache/camel/pull/6810#issuecomment-1020037735
You can make a PR as "draft", by clicking the drop down arrow on the green button, and there is a "convert to draft" or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org