You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/15 04:43:23 UTC

[GitHub] [skywalking-eyes] zooltd commented on a change in pull request #71: Enhance Npm Resolver: support recording license contents

zooltd commented on a change in pull request #71:
URL: https://github.com/apache/skywalking-eyes/pull/71#discussion_r708832783



##########
File path: pkg/deps/result.go
##########
@@ -31,10 +31,12 @@ const (
 
 // Result is a single item that represents a resolved dependency license.
 type Result struct {
-	Dependency      string
-	LicenseFilePath string
-	LicenseContent  string
-	LicenseSpdxID   string
+	Dependency       string
+	LicenseFilePath  string
+	LicenseContent   string
+	LicenseSpdxID    string
+	ManifestFilePath string

Review comment:
       Nope. The `ManifestFilePath` field seems redundent. I'm gonna delete this field.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org