[jira] [Assigned] (SPARK-23683) FileCommitProtocol.instantiate to require 3-arg constructor for dynamic partition overwrite

["Apache Spark (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-23683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Apache Spark reassigned SPARK-23683:
------------------------------------

    Assignee:     (was: Apache Spark)

> FileCommitProtocol.instantiate to require 3-arg constructor for dynamic partition overwrite
> -------------------------------------------------------------------------------------------
>
>                 Key: SPARK-23683
>                 URL: https://issues.apache.org/jira/browse/SPARK-23683
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 2.3.0
>            Reporter: Steve Loughran
>            Priority: Major
>
> with SPARK-20236 {{FileCommitProtocol.instantiate()}} looks for a three argument constructor, passing in the {{dynamicPartitionOverwrite}} parameter. If there is no such constructor, it falls back to the classic two-arg one.
> When {{InsertIntoHadoopFsRelationCommand}} passes down that {{dynamicPartitionOverwrite}} flag to  {{FileCommitProtocol.instantiate()}}, it _assumes_ that the instantiated protocol supports the specific requirements of dynamic partition overwrite. It does not notice when this does not hold, and so the output generated may be incorrect.
> Proposed: when dynamicPartitionOverwrite == true, require the protocol implementation to have a 3-arg constructor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org