Re: [PR] chores: Add lint rule to enforce string formatting style [datafusion]

["kosiew (via GitHub)" <gi...@apache.org>]

kosiew commented on code in PR #16024:
URL: https://github.com/apache/datafusion/pull/16024#discussion_r2083735160


##########
datafusion/ffi/src/tests/async_provider.rs:
##########
@@ -270,7 +270,7 @@ impl Stream for AsyncTestRecordBatchStream {
                 None => std::task::Poll::Ready(None),
             },
             Err(e) => std::task::Poll::Ready(Some(Err(DataFusionError::Execution(
-                format!("Unable receive record batch: {}", e),
+                format!("Unable receive record batch: {e}"),

Review Comment:
   ```suggestion
                   format!("Unable to receive record batch: {e}"),
   ```



##########
datafusion/functions/src/datetime/to_date.rs:
##########
@@ -482,10 +481,7 @@ mod tests {
             invoke_to_date_with_args(vec![ColumnarValue::Scalar(date_scalar)], 1);
 
         if let Ok(ColumnarValue::Scalar(ScalarValue::Date32(_))) = to_date_result {
-            panic!(
-                "Conversion of {} succeeded, but should have failed, ",
-                date_str
-            );
+            panic!("Conversion of {date_str} succeeded, but should have failed, ");

Review Comment:
   ```suggestion
               panic!("Conversion of {date_str} succeeded, but should have failed. ");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org