You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/12/23 07:13:11 UTC
[GitHub] jmeter pull request #365: Expanded Checkstyle to files in src and test; fixe...
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/365
Expanded Checkstyle to files in src and test; fixed newly checked files
## Description
Added `test` to the files being checked.
## Motivation and Context
Felix and Philippe found some groovy files without the headers, this fixes Checkstyle not picking that up.
## How Has This Been Tested?
`and checkstyle`
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter increase_checkstyle_file_coverage
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/365.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #365
----
commit 6f2c28508b0f3b0f1873a1702d5867aaf8790e15
Author: Graham Russell <gr...@...>
Date: 2017-12-20T14:50:21Z
Expanded Checkstyle to files in src and test; fixed newly checked files
----
---
[GitHub] jmeter issue #365: Expanded Checkstyle to files in src and test; fixed newly...
Posted by ham1 <gi...@git.apache.org>.
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/365
Thanks for committing!
---
[GitHub] jmeter issue #365: Expanded Checkstyle to files in src and test; fixed newly...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/365
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/365?src=pr&el=h1) Report
> Merging [#365](https://codecov.io/gh/apache/jmeter/pull/365?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/998b3302a10ad8f298c12e67e08369f5a205018d?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `60.71%`.
[](https://codecov.io/gh/apache/jmeter/pull/365?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #365 +/- ##
============================================
+ Coverage 58.35% 58.35% +<.01%
- Complexity 10288 10290 +2
============================================
Files 1164 1164
Lines 74127 74135 +8
Branches 7298 7298
============================================
+ Hits 43254 43263 +9
Misses 28359 28359
+ Partials 2514 2513 -1
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/365?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...mpler/TestHTTPSamplersAgainstHttpMirrorServer.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9zYW1wbGVyL1Rlc3RIVFRQU2FtcGxlcnNBZ2FpbnN0SHR0cE1pcnJvclNlcnZlci5qYXZh) | `89.75% <ø> (ø)` | `80 <0> (ø)` | :arrow_down: |
| [...g/apache/jmeter/assertions/SMIMEAssertionTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9TTUlNRUFzc2VydGlvblRlc3QuamF2YQ==) | `100% <ø> (ø)` | `9 <0> (ø)` | :arrow_down: |
| [...er/protocol/http/control/TestHTTPMirrorThread.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb250cm9sL1Rlc3RIVFRQTWlycm9yVGhyZWFkLmphdmE=) | `90% <ø> (ø)` | `26 <0> (ø)` | :arrow_down: |
| [...apache/jmeter/functions/TestTimeShiftFunction.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1Rlc3RUaW1lU2hpZnRGdW5jdGlvbi5qYXZh) | `89.32% <ø> (ø)` | `12 <0> (ø)` | :arrow_down: |
| [...pache/jmeter/assertions/ResponseAssertionTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvYXNzZXJ0aW9ucy9SZXNwb25zZUFzc2VydGlvblRlc3QuamF2YQ==) | `99.03% <ø> (ø)` | `14 <0> (ø)` | :arrow_down: |
| [...t/src/org/apache/jmeter/functions/PackageTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL1BhY2thZ2VUZXN0LmphdmE=) | `91.63% <ø> (ø)` | `25 <0> (ø)` | :arrow_down: |
| [...rg/apache/jmeter/visualizers/TestRenderAsJson.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvVGVzdFJlbmRlckFzSnNvbi5qYXZh) | `100% <ø> (ø)` | `10 <0> (ø)` | :arrow_down: |
| [.../org/apache/jmeter/functions/ChangeCaseSpec.groovy](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZnVuY3Rpb25zL0NoYW5nZUNhc2VTcGVjLmdyb292eQ==) | `100% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
| [...che/jmeter/protocol/http/config/UrlConfigTest.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvcHJvdG9jb2wvaHR0cC9jb25maWcvVXJsQ29uZmlnVGVzdC5qYXZh) | `100% <ø> (ø)` | `4 <0> (ø)` | :arrow_down: |
| [...est/src/org/apache/jorphan/util/TestConverter.java](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qb3JwaGFuL3V0aWwvVGVzdENvbnZlcnRlci5qYXZh) | `100% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/jmeter/pull/365/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/365?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/365?src=pr&el=footer). Last update [998b330...08615ed](https://codecov.io/gh/apache/jmeter/pull/365?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter issue #365: Expanded Checkstyle to files in src and test; fixed newly...
Posted by FSchumacher <gi...@git.apache.org>.
Github user FSchumacher commented on the issue:
https://github.com/apache/jmeter/pull/365
Thanks for your contribution.
---
[GitHub] jmeter pull request #365: Expanded Checkstyle to files in src and test; fixe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/365
---