You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/21 22:47:59 UTC
[GitHub] [nifi] alopresto opened a new pull request #4419: NIFI-7660 Resolved failing unit test on Azul Zulu JDK 8 update 262.
alopresto opened a new pull request #4419:
URL: https://github.com/apache/nifi/pull/4419
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_The Azul Zulu JDK 8 update 262 introduced TLS v1.3 to Java 8 but throws a different exception than other vendors (`SSLHandshakeException` vs. `IllegalArgumentException`) when 1.3 is requested if it's not configured._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #4419: NIFI-7660 Resolved failing unit test on Azul Zulu JDK 8 update 262.
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4419:
URL: https://github.com/apache/nifi/pull/4419#issuecomment-662152227
Have looked into this and indeed the issue is only present for azul jdk 8 262 and the failure happens on osx/linux and windows. However, for other jvms such as adoptopenjdk it works just fine as it did before. there is at least an inconsistency in the exception being thrown between these different jvm providers. ugh. Therefore I think the PR is a sufficient and necessary step at this point while ensuring only versions of azul 262 or later would have this test bypassed which is fair.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4419: NIFI-7660 Resolved failing unit test on Azul Zulu JDK 8 update 262.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4419:
URL: https://github.com/apache/nifi/pull/4419
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #4419: NIFI-7660 Resolved failing unit test on Azul Zulu JDK 8 update 262.
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #4419:
URL: https://github.com/apache/nifi/pull/4419#issuecomment-662152305
waiting for github actions/ci to do its thing but once good then will pull this in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org