[jira] [Commented] (OOZIE-1638) Action retry does not use default retry max count.

["purshotam shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13869741#comment-13869741 ] 

purshotam shah commented on OOZIE-1638:
---------------------------------------

Comment on Patch.


+final WorkflowActionsGetForJobJPAExecutor actionsGetExecutor = new WorkflowActionsGetForJobJPAExecutor(jobId);
+        waitFor(5000, new Predicate() {
+            public boolean evaluate() throws Exception {
+                List<WorkflowActionBean> actions = jpaService.execute(actionsGetExecutor);
+                WorkflowActionBean action = null;
+                for (WorkflowActionBean bean : actions) {
+                    if (bean.getType().equals("test")) {
+                        action = bean;
+                        break;
+                    }
+                }
+            >>>    return (action != null && action.getUserRetryCount() == max);
+            }
+        });


You should break when action is succeeded or failed and then check getUserRetryCount()


>>+<workflow-app xmlns="uri:oozie:workflow:0.3" name="test-wf">
Why not to use latest version 0.5

> Action retry does not use default retry max count.
> --------------------------------------------------
>
>                 Key: OOZIE-1638
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1638
>             Project: Oozie
>          Issue Type: Bug
>          Components: action
>    Affects Versions: 4.0.0
>            Reporter: Azrael
>            Priority: Minor
>         Attachments: OOZIE-1638.2.patch, OOZIE-1638.3.patch, OOZIE-1638.patch
>
>
> the oozie-default
> {code:xml}
> <property>
>         <name>oozie.service.LiteWorkflowStoreService.user.retry.max</name>
>         <value>3</value>
>         <description>
>             Automatic retry max count for workflow action is 3 in default.
>         </description>
> </property>
> {code}
> but the action failed with error, is not retried. 
> It should retry $\{user.retry.max\} times.
> If the patch applied, some other tests in TestActionError failed because the action is not terminated for retrying.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)