You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "jiaoqingbo (via GitHub)" <gi...@apache.org> on 2023/03/13 09:57:28 UTC
[GitHub] [incubator-celeborn] jiaoqingbo opened a new pull request, #1338: [CELEBORN-412] In the cleanupOldFiles method of the StateMachine class, when onlyCleanupMD5Files is true, md5flie should be deleted instead of file
jiaoqingbo opened a new pull request, #1338:
URL: https://github.com/apache/incubator-celeborn/pull/1338
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
In the cleanupOldFiles method of the StateMachine class, when onlyCleanupMD5Files is true, md5flie should be deleted instead of file
### Why are the changes needed?
In the cleanupOldFiles method of the StateMachine class, when onlyCleanupMD5Files is true, md5flie should be deleted instead of file
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
passing CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] jiaoqingbo closed pull request #1338: [CELEBORN-412] In the cleanupOldFiles method of the StateMachine class, when onlyCleanupMD5Files is true, md5flie should be deleted instead of file
Posted by "jiaoqingbo (via GitHub)" <gi...@apache.org>.
jiaoqingbo closed pull request #1338: [CELEBORN-412] In the cleanupOldFiles method of the StateMachine class, when onlyCleanupMD5Files is true, md5flie should be deleted instead of file
URL: https://github.com/apache/incubator-celeborn/pull/1338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] jiaoqingbo commented on pull request #1338: [CELEBORN-412] In the cleanupOldFiles method of the StateMachine class, when onlyCleanupMD5Files is true, md5flie should be deleted instead of file
Posted by "jiaoqingbo (via GitHub)" <gi...@apache.org>.
jiaoqingbo commented on PR #1338:
URL: https://github.com/apache/incubator-celeborn/pull/1338#issuecomment-1467459107
Sorry, I reviewed the code and UT, and found that the previous logic was correct. I will close this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1338: [CELEBORN-412] In the cleanupOldFiles method of the StateMachine class, when onlyCleanupMD5Files is true, md5flie should be deleted instead of file
Posted by "AngersZhuuuu (via GitHub)" <gi...@apache.org>.
AngersZhuuuu commented on PR #1338:
URL: https://github.com/apache/incubator-celeborn/pull/1338#issuecomment-1465859629
Pls fix the failed UT too
```
org.apache.celeborn.service.deploy.master.clustermeta.ha.MasterStateMachineSuiteJ.testSnapshotCleanup Time elapsed: 0.074 s <<< FAILURE!
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.celeborn.service.deploy.master.clustermeta.ha.MasterStateMachineSuiteJ.testSnapshotCleanup(MasterStateMachineSuiteJ.java:166)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:377)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:284)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:248)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:167)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org