You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2016/02/25 09:30:52 UTC
[1/2] mesos git commit: Used `foreach` loop for iteration.
Repository: mesos
Updated Branches:
refs/heads/master 82ff5ca90 -> 014223c63
Used `foreach` loop for iteration.
Review: https://reviews.apache.org/r/43461/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e421c5a3
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e421c5a3
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e421c5a3
Branch: refs/heads/master
Commit: e421c5a3b1ec4e59c5f42fda615b50b7143b85a8
Parents: 82ff5ca
Author: Cong Wang <xi...@gmail.com>
Authored: Wed Feb 24 23:19:21 2016 -0800
Committer: Michael Park <mp...@apache.org>
Committed: Wed Feb 24 23:33:53 2016 -0800
----------------------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/e421c5a3/3rdparty/libprocess/include/process/future.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/include/process/future.hpp b/3rdparty/libprocess/include/process/future.hpp
index 77655f2..9439b73 100644
--- a/3rdparty/libprocess/include/process/future.hpp
+++ b/3rdparty/libprocess/include/process/future.hpp
@@ -788,13 +788,12 @@ Future<Future<T>> select(const std::set<Future<T>>& futures)
promise->future().onDiscard(
lambda::bind(&internal::discarded<Future<T>>, promise->future()));
- typename std::set<Future<T>>::iterator iterator;
- for (iterator = futures.begin(); iterator != futures.end(); ++iterator) {
+ foreach (const Future<T>& future, futures) {
// NOTE: We can't use std::bind with a std::function with Clang
// like we do below (see
// http://stackoverflow.com/questions/20097616/stdbind-to-a-stdfunction-crashes-with-clang).
- (*iterator).onAny([=](const Future<T>& future) {
- internal::select(future, promise);
+ future.onAny([=](const Future<T>& f) {
+ internal::select(f, promise);
});
}
@@ -805,9 +804,7 @@ Future<Future<T>> select(const std::set<Future<T>>& futures)
template <typename T>
void discard(const std::set<Future<T>>& futures)
{
- typename std::set<Future<T>>::const_iterator iterator;
- for (iterator = futures.begin(); iterator != futures.end(); ++iterator) {
- Future<T> future = *iterator; // Need a non-const copy to discard.
+ foreach (Future<T> future, futures) { // Need a non-const copy to discard.
future.discard();
}
}
@@ -816,9 +813,7 @@ void discard(const std::set<Future<T>>& futures)
template <typename T>
void discard(const std::list<Future<T>>& futures)
{
- typename std::list<Future<T>>::const_iterator iterator;
- for (iterator = futures.begin(); iterator != futures.end(); ++iterator) {
- Future<T> future = *iterator; // Need a non-const copy to discard.
+ foreach (Future<T> future, futures) { // Need a non-const copy to discard.
future.discard();
}
}
[2/2] mesos git commit: Removed a stale comment from `future.hpp`.
Posted by mp...@apache.org.
Removed a stale comment from `future.hpp`.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/014223c6
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/014223c6
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/014223c6
Branch: refs/heads/master
Commit: 014223c633f90bef0f7c419ff67fb7a0924a33ee
Parents: e421c5a
Author: Michael Park <mp...@apache.org>
Authored: Wed Feb 24 23:29:13 2016 -0800
Committer: Michael Park <mp...@apache.org>
Committed: Wed Feb 24 23:36:07 2016 -0800
----------------------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp | 3 ---
1 file changed, 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/014223c6/3rdparty/libprocess/include/process/future.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/include/process/future.hpp b/3rdparty/libprocess/include/process/future.hpp
index 9439b73..2531fa9 100644
--- a/3rdparty/libprocess/include/process/future.hpp
+++ b/3rdparty/libprocess/include/process/future.hpp
@@ -789,9 +789,6 @@ Future<Future<T>> select(const std::set<Future<T>>& futures)
lambda::bind(&internal::discarded<Future<T>>, promise->future()));
foreach (const Future<T>& future, futures) {
- // NOTE: We can't use std::bind with a std::function with Clang
- // like we do below (see
- // http://stackoverflow.com/questions/20097616/stdbind-to-a-stdfunction-crashes-with-clang).
future.onAny([=](const Future<T>& f) {
internal::select(f, promise);
});