You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:34:35 UTC
[GitHub] [incubator-superset] etr2460 opened a new pull request #10478: fix: timeout error message
etr2460 opened a new pull request #10478:
URL: https://github.com/apache/incubator-superset/pull/10478
### SUMMARY
My past PR accidentally snuck a bit of hard coding through, this now correctly pulls the timeout param from SupersetClient and displays it in the error message
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="647" alt="Screen Shot 2020-07-29 at 3 24 01 PM" src="https://user-images.githubusercontent.com/7409244/88860640-0dd99000-d1b1-11ea-90c7-251422d7cfa5.png">
### TEST PLAN
Change the config timeout and add a sleep to the backend, see the correct timeout value shown here
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @ktmud @kristw @nytai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 merged pull request #10478: fix: timeout error message
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #10478:
URL: https://github.com/apache/incubator-superset/pull/10478
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org