You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/02 13:17:03 UTC
[GitHub] [beam] scwhittle opened a new pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
scwhittle opened a new pull request #16983:
URL: https://github.com/apache/beam/pull/16983
This prevents many unnecessary counter updates in the case of Dataflow
streaming pipelines when resets occur frequently.
Add missing HIstogramCellTest.java and add HistogramData equality/hash operators for that test.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #16983:
URL: https://github.com/apache/beam/pull/16983#issuecomment-1070783006
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #16983:
URL: https://github.com/apache/beam/pull/16983#issuecomment-1060656605
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #16983:
URL: https://github.com/apache/beam/pull/16983#issuecomment-1070532867
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #16983:
URL: https://github.com/apache/beam/pull/16983#issuecomment-1070783278
Retrying precommit, different tests are failing each time and they seem unrelated to this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #16983:
URL: https://github.com/apache/beam/pull/16983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #16983:
URL: https://github.com/apache/beam/pull/16983#issuecomment-1063837636
Fixed spotbugs due to forgetting to synchronize added HistogramData equals and hashCode methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle closed pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle closed pull request #16983:
URL: https://github.com/apache/beam/pull/16983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle closed pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle closed pull request #16983:
URL: https://github.com/apache/beam/pull/16983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle closed pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle closed pull request #16983:
URL: https://github.com/apache/beam/pull/16983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #16983:
URL: https://github.com/apache/beam/pull/16983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #16983:
URL: https://github.com/apache/beam/pull/16983#issuecomment-1070978489
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #16983:
URL: https://github.com/apache/beam/pull/16983#issuecomment-1066974019
Reopening to retrigger checks, last failure seemed like an unrelated gradle issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #16983:
URL: https://github.com/apache/beam/pull/16983#issuecomment-1056920685
R: @lukecwik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] scwhittle commented on pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
scwhittle commented on pull request #16983:
URL: https://github.com/apache/beam/pull/16983#issuecomment-1069405745
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #16983: [BEAM-13015] Modify metrics to begin and reset to a non-dirty state.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #16983:
URL: https://github.com/apache/beam/pull/16983#issuecomment-1070978489
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org