You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "newkek (GitHub)" <gi...@apache.org> on 2019/03/18 20:31:45 UTC

[GitHub] [tinkerpop] newkek opened pull request #1084: TINKERPOP-2179: Have SerializationException extend IOException [master]

Same as #1083 but with some minor changes to some errors thrown in the GraphBinary serialization.

I did a `merge -s ours` of the branch `TINKERPOP-2179` to this branch first and then added another commit https://github.com/apache/tinkerpop/commit/00954a92fec41eb19626f050585ad1f300dbd9bf. A merge without the `-s ours` was causing conflicts in all the pom.xml for some reason?

[ Full content available at: https://github.com/apache/tinkerpop/pull/1084 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] newkek commented on issue #1084: TINKERPOP-2179: Have SerializationException extend IOException [master]

Posted by "newkek (GitHub)" <gi...@apache.org>.
Yes I'll rebase, no worries.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1084 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1084: TINKERPOP-2179: Have SerializationException extend IOException [master]

Posted by "spmallette (GitHub)" <gi...@apache.org>.
@newkek sorry, but i guess you should try your rebase again - perhaps things are straightened out in `master` now and will allow a cleaner merge from `tp33` than you were experiencing before?

[ Full content available at: https://github.com/apache/tinkerpop/pull/1084 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette closed pull request #1084: TINKERPOP-2179: Have SerializationException extend IOException [master]

Posted by "spmallette (GitHub)" <gi...@apache.org>.
[ pull request closed by spmallette ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1084 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org