Re: [PR] HOTFIX: Fix GroupMetadataManager#completeAlterShareGroupOffsets to use InitMapValue in addInitializingTopicsRecords [kafka]

["Yunyung (via GitHub)" <gi...@apache.org>]

Yunyung commented on code in PR #19792:
URL: https://github.com/apache/kafka/pull/19792#discussion_r2104219802


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8136,10 +8136,15 @@ public Map.Entry<AlterShareGroupOffsetsResponseData, InitializeShareGroupStatePa
                     }
                 });
 
-                initializingTopics.put(topicId, topic.partitions().stream()
-                    .map(AlterShareGroupOffsetsRequestData.AlterShareGroupOffsetsRequestPartition::partitionIndex)
-                    .filter(existingPartitions::contains)
-                    .collect(Collectors.toSet()));
+                long curTimestamp = time.milliseconds();

Review Comment:
   Move time.milliseconds() out of the loop so that all iterations have the same timestamp.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org