You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Philipp Moritz (JIRA)" <ji...@apache.org> on 2018/04/03 20:02:00 UTC
[jira] [Created] (ARROW-2386) [Plasma] Change PlasmaClient::Create
API
Philipp Moritz created ARROW-2386:
-------------------------------------
Summary: [Plasma] Change PlasmaClient::Create API
Key: ARROW-2386
URL: https://issues.apache.org/jira/browse/ARROW-2386
Project: Apache Arrow
Issue Type: Improvement
Components: Plasma (C++)
Reporter: Philipp Moritz
Now that the Get API is refactored in [https://github.com/apache/arrow/pull/1807,] we should do the same for the Create API.
Proposal:
Have a MutablePlasmaBuffer class, which is returned by Create
{code:java}
Status Create(int64_t data_size, int64_t metadata_size, std::shared_ptr<MutablePlasmaBuffer>* buffer)
{code}
This allocates the data in shared memory, but does not associate it with the object id yet. This way we get get rid of the Abort() call.
Move the Seal() method into the MutablePlasmaBuffer and let it return the object ID.
This is very similar to what [~pitrou] suggested here: https://github.com/apache/arrow/pull/1807
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)