You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/07/22 12:57:51 UTC
Review Request 36682: LENS-668 : Use Slf4j in lens-server module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36682/
-----------------------------------------------------------
Review request for lens and Raju Bairishetti.
Bugs: LENS-668
https://issues.apache.org/jira/browse/LENS-668
Repository: lens
Description
-------
Checked all occurences of commons.logging and log4j through git grep and replaced.
Diffs
-----
lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java e39c7a2
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
lens-server/src/main/java/org/apache/lens/server/LensApplication.java a3079cc
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 2c8ce46
lens-server/src/main/java/org/apache/lens/server/LensServer.java d4c89c0
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/LensServices.java fe58e96
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java cb9516b
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 757205a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 877e296
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 447d638
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 2a5cce5
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 5344fee
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 305c031
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 71d29b4
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 391cf08
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java cd1ba36
lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 8563951
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
lens-server/src/test/java/org/apache/lens/server/TestResource.java da07a6c
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 3fb123e
lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java cf3b579
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 4eb52b9
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 118970d
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java a77378b
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java f3f2cac
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 0b152bf
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java ea81e90
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 9a79e65
lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java a122d1e
Diff: https://reviews.apache.org/r/36682/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.979s]
[INFO] Lens .............................................. SUCCESS [2.847s]
[INFO] Lens API .......................................... SUCCESS [22.822s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.501s]
[INFO] Lens Cube ......................................... SUCCESS [4:16.324s]
[INFO] Lens DB storage ................................... SUCCESS [19.601s]
[INFO] Lens Query Library ................................ SUCCESS [14.542s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:47.146s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.859s]
[INFO] Lens Server ....................................... SUCCESS [6:14.367s]
[INFO] Lens client ....................................... SUCCESS [39.556s]
[INFO] Lens CLI .......................................... SUCCESS [2:41.204s]
[INFO] Lens Examples ..................................... SUCCESS [8.374s]
[INFO] Lens Distribution ................................. SUCCESS [8.035s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.692s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.950s]
[INFO] Lens Regression ................................... SUCCESS [11.652s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:27.293s
[INFO] Finished at: Wed Jul 22 06:51:39 UTC 2015
[INFO] Final Memory: 190M/2132M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36682: LENS-668 : Use Slf4j in lens-server module
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36682/#review92580
-----------------------------------------------------------
Fix and ship it
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java (line 91)
<https://reviews.apache.org/r/36682/#comment146779>
**{}** placeholder missing?
- Raju Bairishetti
On July 22, 2015, 10:57 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36682/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 10:57 a.m.)
>
>
> Review request for lens and Raju Bairishetti.
>
>
> Bugs: LENS-668
> https://issues.apache.org/jira/browse/LENS-668
>
>
> Repository: lens
>
>
> Description
> -------
>
> Checked all occurences of commons.logging and log4j through git grep and replaced.
>
>
> Diffs
> -----
>
> lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java e39c7a2
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensApplication.java a3079cc
> lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 2c8ce46
> lens-server/src/main/java/org/apache/lens/server/LensServer.java d4c89c0
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/LensServices.java fe58e96
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java cb9516b
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 757205a
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 877e296
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 447d638
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 2a5cce5
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 5344fee
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 305c031
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 71d29b4
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 391cf08
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java cd1ba36
> lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 8563951
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java fb3e67b
> lens-server/src/test/java/org/apache/lens/server/TestResource.java da07a6c
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
> lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 3fb123e
> lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java cf3b579
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 4eb52b9
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 118970d
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java a77378b
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java f3f2cac
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 0b152bf
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java ea81e90
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 9a79e65
> lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java a122d1e
>
> Diff: https://reviews.apache.org/r/36682/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.979s]
> [INFO] Lens .............................................. SUCCESS [2.847s]
> [INFO] Lens API .......................................... SUCCESS [22.822s]
> [INFO] Lens API for server and extensions ................ SUCCESS [18.501s]
> [INFO] Lens Cube ......................................... SUCCESS [4:16.324s]
> [INFO] Lens DB storage ................................... SUCCESS [19.601s]
> [INFO] Lens Query Library ................................ SUCCESS [14.542s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:47.146s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.859s]
> [INFO] Lens Server ....................................... SUCCESS [6:14.367s]
> [INFO] Lens client ....................................... SUCCESS [39.556s]
> [INFO] Lens CLI .......................................... SUCCESS [2:41.204s]
> [INFO] Lens Examples ..................................... SUCCESS [8.374s]
> [INFO] Lens Distribution ................................. SUCCESS [8.035s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.692s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.950s]
> [INFO] Lens Regression ................................... SUCCESS [11.652s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:27.293s
> [INFO] Finished at: Wed Jul 22 06:51:39 UTC 2015
> [INFO] Final Memory: 190M/2132M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36682: LENS-668 : Use Slf4j in lens-server module
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36682/#review92593
-----------------------------------------------------------
Ship it!
Ship It!
- Raju Bairishetti
On July 22, 2015, 12:48 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36682/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 12:48 p.m.)
>
>
> Review request for lens and Raju Bairishetti.
>
>
> Bugs: LENS-668
> https://issues.apache.org/jira/browse/LENS-668
>
>
> Repository: lens
>
>
> Description
> -------
>
> Checked all occurences of commons.logging and log4j through git grep and replaced.
>
>
> Diffs
> -----
>
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 67e3379
> lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java e39c7a2
> lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
> lens-server/src/main/java/org/apache/lens/server/LensApplication.java a3079cc
> lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 2c8ce46
> lens-server/src/main/java/org/apache/lens/server/LensServer.java d4c89c0
> lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
> lens-server/src/main/java/org/apache/lens/server/LensServices.java fe58e96
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java cb9516b
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 757205a
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e5fcd5
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 877e296
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 447d638
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 2a5cce5
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 5344fee
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 305c031
> lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 71d29b4
> lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 391cf08
> lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java cd1ba36
> lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 8563951
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 44aa0aa
> lens-server/src/test/java/org/apache/lens/server/TestResource.java da07a6c
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
> lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 3fb123e
> lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java cf3b579
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 4eb52b9
> lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 118970d
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java a77378b
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java f3f2cac
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 0b152bf
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java ea81e90
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 9a79e65
> lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java a122d1e
>
> Diff: https://reviews.apache.org/r/36682/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.187s]
> [INFO] Lens .............................................. SUCCESS [3.143s]
> [INFO] Lens API .......................................... SUCCESS [21.979s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.806s]
> [INFO] Lens Cube ......................................... SUCCESS [4:17.149s]
> [INFO] Lens DB storage ................................... SUCCESS [20.376s]
> [INFO] Lens Query Library ................................ SUCCESS [14.301s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:52.559s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [34.516s]
> [INFO] Lens Server ....................................... SUCCESS [5:28.470s]
> [INFO] Lens client ....................................... SUCCESS [42.448s]
> [INFO] Lens CLI .......................................... SUCCESS [2:39.807s]
> [INFO] Lens Examples ..................................... SUCCESS [8.424s]
> [INFO] Lens Distribution ................................. SUCCESS [8.011s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.743s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.658s]
> [INFO] Lens Regression ................................... SUCCESS [10.135s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:45.666s
> [INFO] Finished at: Wed Jul 22 12:33:35 UTC 2015
> [INFO] Final Memory: 203M/2208M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 36682: LENS-668 : Use Slf4j in lens-server module
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36682/
-----------------------------------------------------------
(Updated July 22, 2015, 12:48 p.m.)
Review request for lens and Raju Bairishetti.
Bugs: LENS-668
https://issues.apache.org/jira/browse/LENS-668
Repository: lens
Description
-------
Checked all occurences of commons.logging and log4j through git grep and replaced.
Diffs
-----
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 67e3379
lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java e39c7a2
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
lens-server/src/main/java/org/apache/lens/server/LensApplication.java a3079cc
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 2c8ce46
lens-server/src/main/java/org/apache/lens/server/LensServer.java d4c89c0
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/LensServices.java fe58e96
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java cb9516b
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 757205a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e5fcd5
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 877e296
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 447d638
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 2a5cce5
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 5344fee
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 305c031
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 71d29b4
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 391cf08
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java cd1ba36
lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 8563951
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 44aa0aa
lens-server/src/test/java/org/apache/lens/server/TestResource.java da07a6c
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 3fb123e
lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java cf3b579
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 4eb52b9
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 118970d
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java a77378b
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java f3f2cac
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 0b152bf
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java ea81e90
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 9a79e65
lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java a122d1e
Diff: https://reviews.apache.org/r/36682/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.187s]
[INFO] Lens .............................................. SUCCESS [3.143s]
[INFO] Lens API .......................................... SUCCESS [21.979s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.806s]
[INFO] Lens Cube ......................................... SUCCESS [4:17.149s]
[INFO] Lens DB storage ................................... SUCCESS [20.376s]
[INFO] Lens Query Library ................................ SUCCESS [14.301s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:52.559s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [34.516s]
[INFO] Lens Server ....................................... SUCCESS [5:28.470s]
[INFO] Lens client ....................................... SUCCESS [42.448s]
[INFO] Lens CLI .......................................... SUCCESS [2:39.807s]
[INFO] Lens Examples ..................................... SUCCESS [8.424s]
[INFO] Lens Distribution ................................. SUCCESS [8.011s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.743s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.658s]
[INFO] Lens Regression ................................... SUCCESS [10.135s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:45.666s
[INFO] Finished at: Wed Jul 22 12:33:35 UTC 2015
[INFO] Final Memory: 203M/2208M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36682: LENS-668 : Use Slf4j in lens-server module
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36682/
-----------------------------------------------------------
(Updated July 22, 2015, 12:21 p.m.)
Review request for lens and Raju Bairishetti.
Changes
-------
More merge issues
Bugs: LENS-668
https://issues.apache.org/jira/browse/LENS-668
Repository: lens
Description
-------
Checked all occurences of commons.logging and log4j through git grep and replaced.
Diffs (updated)
-----
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 67e3379
lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java e39c7a2
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
lens-server/src/main/java/org/apache/lens/server/LensApplication.java a3079cc
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 2c8ce46
lens-server/src/main/java/org/apache/lens/server/LensServer.java d4c89c0
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/LensServices.java fe58e96
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java cb9516b
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 757205a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e5fcd5
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 877e296
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 447d638
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 2a5cce5
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 5344fee
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 305c031
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 71d29b4
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 391cf08
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java cd1ba36
lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 8563951
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 44aa0aa
lens-server/src/test/java/org/apache/lens/server/TestResource.java da07a6c
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 3fb123e
lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java cf3b579
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 4eb52b9
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 118970d
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java a77378b
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java f3f2cac
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 0b152bf
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java ea81e90
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 9a79e65
lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java a122d1e
Diff: https://reviews.apache.org/r/36682/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.979s]
[INFO] Lens .............................................. SUCCESS [2.847s]
[INFO] Lens API .......................................... SUCCESS [22.822s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.501s]
[INFO] Lens Cube ......................................... SUCCESS [4:16.324s]
[INFO] Lens DB storage ................................... SUCCESS [19.601s]
[INFO] Lens Query Library ................................ SUCCESS [14.542s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:47.146s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.859s]
[INFO] Lens Server ....................................... SUCCESS [6:14.367s]
[INFO] Lens client ....................................... SUCCESS [39.556s]
[INFO] Lens CLI .......................................... SUCCESS [2:41.204s]
[INFO] Lens Examples ..................................... SUCCESS [8.374s]
[INFO] Lens Distribution ................................. SUCCESS [8.035s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.692s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.950s]
[INFO] Lens Regression ................................... SUCCESS [11.652s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:27.293s
[INFO] Finished at: Wed Jul 22 06:51:39 UTC 2015
[INFO] Final Memory: 190M/2132M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 36682: LENS-668 : Use Slf4j in lens-server module
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36682/
-----------------------------------------------------------
(Updated July 22, 2015, 12:05 p.m.)
Review request for lens and Raju Bairishetti.
Changes
-------
Fixed review comment and merged with master
Bugs: LENS-668
https://issues.apache.org/jira/browse/LENS-668
Repository: lens
Description
-------
Checked all occurences of commons.logging and log4j through git grep and replaced.
Diffs (updated)
-----
lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java e39c7a2
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 5855ac6
lens-server/src/main/java/org/apache/lens/server/LensApplication.java a3079cc
lens-server/src/main/java/org/apache/lens/server/LensApplicationListener.java 2c8ce46
lens-server/src/main/java/org/apache/lens/server/LensServer.java d4c89c0
lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a
lens-server/src/main/java/org/apache/lens/server/LensServices.java fe58e96
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java cb9516b
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 757205a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 9e5fcd5
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 877e296
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 447d638
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 2a5cce5
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 5344fee
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogFileScannerTask.java 305c031
lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 71d29b4
lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 391cf08
lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java cd1ba36
lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 8563951
lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java 44aa0aa
lens-server/src/test/java/org/apache/lens/server/TestResource.java da07a6c
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java a84fcd3
lens-server/src/test/java/org/apache/lens/server/TestStartupOnMetastoreDown.java 3fb123e
lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java cf3b579
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 4eb52b9
lens-server/src/test/java/org/apache/lens/server/metrics/TestResourceMethodMetrics.java 118970d
lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java a77378b
lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java f3f2cac
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java 0b152bf
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java ea81e90
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 9a79e65
lens-server/src/test/java/org/apache/lens/server/user/TestUserConfigLoader.java a122d1e
Diff: https://reviews.apache.org/r/36682/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.979s]
[INFO] Lens .............................................. SUCCESS [2.847s]
[INFO] Lens API .......................................... SUCCESS [22.822s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.501s]
[INFO] Lens Cube ......................................... SUCCESS [4:16.324s]
[INFO] Lens DB storage ................................... SUCCESS [19.601s]
[INFO] Lens Query Library ................................ SUCCESS [14.542s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:47.146s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.859s]
[INFO] Lens Server ....................................... SUCCESS [6:14.367s]
[INFO] Lens client ....................................... SUCCESS [39.556s]
[INFO] Lens CLI .......................................... SUCCESS [2:41.204s]
[INFO] Lens Examples ..................................... SUCCESS [8.374s]
[INFO] Lens Distribution ................................. SUCCESS [8.035s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.692s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.950s]
[INFO] Lens Regression ................................... SUCCESS [11.652s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:27.293s
[INFO] Finished at: Wed Jul 22 06:51:39 UTC 2015
[INFO] Final Memory: 190M/2132M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu