[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6975: Core: Minor refactoring of PartitionsTable

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #6975:
URL: https://github.com/apache/iceberg/pull/6975#discussion_r1122630034


##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -45,9 +45,14 @@ public class PartitionsTable extends BaseMetadataTable {
     this.schema =
         new Schema(
             Types.NestedField.required(1, "partition", Partitioning.partitionType(table)),
-            Types.NestedField.required(2, "record_count", Types.LongType.get()),
-            Types.NestedField.required(3, "file_count", Types.IntegerType.get()),
-            Types.NestedField.required(4, "spec_id", Types.IntegerType.get()));
+            Types.NestedField.required(4, "spec_id", Types.IntegerType.get()),

Review Comment:
   I am not sure about the column order, it feels odd to me to have IDs in 1,4,2,3 order. But that's just personal preference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org