You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/06/10 01:28:49 UTC
[GitHub] [trafficserver] masaori335 commented on a change in pull request #6876: Make Http2ClientSession inactive on EOS event
masaori335 commented on a change in pull request #6876:
URL: https://github.com/apache/trafficserver/pull/6876#discussion_r437809569
##########
File path: proxy/http2/Http2ConnectionState.cc
##########
@@ -1406,6 +1406,8 @@ Http2ConnectionState::release_stream()
if (total_client_streams_count == 0) {
if (fini_received) {
+ ua_session->clear_session_active();
Review comment:
Other `else if` blocks in below have `clear_session_active();` call too. Let me do refactoring in another PR. Definitely, this function ( `release_stream()` ) should be renamed at least, but I'd like to focus on just fixing the issue.
##########
File path: proxy/http2/Http2ConnectionState.cc
##########
@@ -1406,6 +1406,8 @@ Http2ConnectionState::release_stream()
if (total_client_streams_count == 0) {
if (fini_received) {
+ ua_session->clear_session_active();
Review comment:
Other `else if` blocks in below have `clear_session_active();` call too. Let me do refactoring in another PR. Definitely, this function ( `release_stream()` ) should be renamed at least, but I'd like to focus on just fixing the issue here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org