You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/04/21 20:01:03 UTC
Review Request 72410: Updated existing documentation for resource
limits.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
Bugs: MESOS-10115
https://issues.apache.org/jira/browse/MESOS-10115
Repository: mesos
Description
-------
Updated existing documentation for resource limits.
Diffs
-----
docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
Diff: https://reviews.apache.org/r/72410/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220536
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72408, 72409, 72410]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On April 28, 2020, 12:59 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated April 28, 2020, 12:59 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
> docs/task-state-reasons.md 10cb7e08d854ecfd16152fd370e4efe03b327347
> docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0
>
>
> Diff: https://reviews.apache.org/r/72410/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 28, 2020, 9:59 a.m., Qian Zhang wrote:
> > docs/task-state-reasons.md
> > Lines 126-133 (patched)
> > <https://reviews.apache.org/r/72410/diff/2/?file=2229076#file2229076line126>
> >
> > If we revert the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in https://reviews.apache.org/r/72442 , then we do not need to update this doc.
I'm not yet convinced that we should remove the new reason, I'd like to better understand why it's not being sent properly and hopefully fix it.
> On April 28, 2020, 9:59 a.m., Qian Zhang wrote:
> > docs/upgrades.md
> > Lines 52 (patched)
> > <https://reviews.apache.org/r/72410/diff/2/?file=2229077#file2229077line52>
> >
> > I think we'd better to have a general description about the task resource limits feature (like how [quota limits](https://github.com/apache/mesos/blob/master/docs/upgrades.md#1-9-x-quota-guarantees) feature was described) rather than just mention CPU limits here.
I think this document isn't intended to be a changelog, but rather a guide for operators who need to upgrade a cluster. So, I think we should only mention things here which an operator might run into when upgrading a cluster: changes in existing behavior, possible issues that could occur, etc.
Regarding the quota example, IMHO the passage on quota limits could be reduced to the following text:
```
* Quota guarantees, while still functional in Mesos 1.9, are now deprecated. In the future when optimistic offers are fully implemented, a combination of the newly-added quota limits and priority-based preemption will be simpler to use.
```
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220519
-----------------------------------------------------------
On April 28, 2020, 12:59 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated April 28, 2020, 12:59 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
> docs/task-state-reasons.md 10cb7e08d854ecfd16152fd370e4efe03b327347
> docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0
>
>
> Diff: https://reviews.apache.org/r/72410/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 28, 2020, 9:59 a.m., Qian Zhang wrote:
> > docs/task-state-reasons.md
> > Lines 126-133 (patched)
> > <https://reviews.apache.org/r/72410/diff/2/?file=2229076#file2229076line126>
> >
> > If we revert the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in https://reviews.apache.org/r/72442 , then we do not need to update this doc.
>
> Greg Mann wrote:
> I'm not yet convinced that we should remove the new reason, I'd like to better understand why it's not being sent properly and hopefully fix it.
OK, removed!
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220519
-----------------------------------------------------------
On May 7, 2020, 12:35 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated May 7, 2020, 12:35 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md a77a9df0b4f59a65b65fe4a53c737f89571f9fbd
> docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0
>
>
> Diff: https://reviews.apache.org/r/72410/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220519
-----------------------------------------------------------
docs/task-state-reasons.md
Lines 126-133 (patched)
<https://reviews.apache.org/r/72410/#comment308997>
If we revert the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED` in https://reviews.apache.org/r/72442 , then we do not need to update this doc.
docs/upgrades.md
Lines 52 (patched)
<https://reviews.apache.org/r/72410/#comment308998>
I think we'd better to have a general description about the task resource limits feature (like how [quota limits](https://github.com/apache/mesos/blob/master/docs/upgrades.md#1-9-x-quota-guarantees) feature was described) rather than just mention CPU limits here.
- Qian Zhang
On April 28, 2020, 8:59 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated April 28, 2020, 8:59 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
> docs/task-state-reasons.md 10cb7e08d854ecfd16152fd370e4efe03b327347
> docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0
>
>
> Diff: https://reviews.apache.org/r/72410/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220669
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On May 7, 2020, 8:35 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated May 7, 2020, 8:35 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md a77a9df0b4f59a65b65fe4a53c737f89571f9fbd
> docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0
>
>
> Diff: https://reviews.apache.org/r/72410/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/
-----------------------------------------------------------
(Updated May 7, 2020, 12:35 a.m.)
Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
Bugs: MESOS-10115
https://issues.apache.org/jira/browse/MESOS-10115
Repository: mesos
Description
-------
Updated existing documentation for resource limits.
Diffs (updated)
-----
docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
docs/scheduler-http-api.md a77a9df0b4f59a65b65fe4a53c737f89571f9fbd
docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0
Diff: https://reviews.apache.org/r/72410/diff/3/
Changes: https://reviews.apache.org/r/72410/diff/2-3/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220511
-----------------------------------------------------------
Bad patch!
Reviews applied: [72408, 72409, 72410]
Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | tee build_72410"]
Error:
ubuntu-16.04: Pulling from mesos/mesos-build
18d680d61657: Pulling fs layer
0addb6fece63: Pulling fs layer
78e58219b215: Pulling fs layer
eb6959a66df2: Pulling fs layer
1105027a5560: Pulling fs layer
c36946130a38: Pulling fs layer
6a6a5e68faab: Pulling fs layer
80e07249924c: Pulling fs layer
c4c63e2501db: Pulling fs layer
668b207c2829: Pulling fs layer
ed76dddad568: Pulling fs layer
c36946130a38: Waiting
6a6a5e68faab: Waiting
80e07249924c: Waiting
c4c63e2501db: Waiting
eb6959a66df2: Waiting
ed76dddad568: Waiting
668b207c2829: Waiting
0addb6fece63: Verifying Checksum
0addb6fece63: Download complete
78e58219b215: Download complete
eb6959a66df2: Verifying Checksum
eb6959a66df2: Download complete
18d680d61657: Download complete
c36946130a38: Verifying Checksum
c36946130a38: Download complete
80e07249924c: Verifying Checksum
80e07249924c: Download complete
c4c63e2501db: Verifying Checksum
c4c63e2501db: Download complete
6a6a5e68faab: Verifying Checksum
6a6a5e68faab: Download complete
668b207c2829: Verifying Checksum
668b207c2829: Download complete
ed76dddad568: Download complete
18d680d61657: Pull complete
0addb6fece63: Pull complete
78e58219b215: Pull complete
eb6959a66df2: Pull complete
1105027a5560: Verifying Checksum
1105027a5560: Download complete
1105027a5560: Pull complete
c36946130a38: Pull complete
6a6a5e68faab: Pull complete
80e07249924c: Pull complete
c4c63e2501db: Pull complete
668b207c2829: Pull complete
ed76dddad568: Pull complete
Digest: sha256:fa967cbcfb44f55708a3cbc87f245c6d29dd891464db558af56a03ee321526bb
Status: Downloaded newer image for mesos/mesos-build:ubuntu-16.04
docker.io/mesos/mesos-build:ubuntu-16.04
Cloning into '/tmp/SRC'...
Note: checking out '92d2732a0df2e86e65066346f81a25d85c36fa2d'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b <new-branch-name>
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --warnings=all -I m4
autoreconf: configure.ac: tracing
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: running: libtoolize --copy
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: /usr/bin/autoconf --warnings=all
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --no-force --warnings=all
configure.ac:50: installing './ar-lib'
configure.ac:34: installing './compile'
configure.ac:24: installing './config.guess'
configure.ac:24: installing './config.sub'
configure.ac:46: installing './install-sh'
configure.ac:46: installing './missing'
3rdparty/Makefile.am:307: warning: source file '$(HTTP_PARSER)/http_parser.c' is in a subdirectory,
3rdparty/Makefile.am:307: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled. For now, the corresponding output
automake: object file(s) will be placed in the top-level directory. However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
3rdparty/Makefile.am: installing './depcomp'
3rdparty/Makefile.am:262: warning: variable 'GLOG_LDFLAGS' is defined but no program or
3rdparty/Makefile.am:262: library has 'GLOG' as canonical name (possible typo)
3rdparty/stout/Makefile.am:138: warning: source file 'tests/adaptor_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/archiver_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/base64_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/bits_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/boundedhashmap_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/bytes_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/cache_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/cpp17_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/duration_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/dynamiclibrary_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/error_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/flags_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/gzip_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/hashmap_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/hashset_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/interval_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/ip_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/json_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/jsonify_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/lambda_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/linkedhashmap_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/mac_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/main.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/multimap_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/none_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/numify_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/option_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/copyfile_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/env_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/filesystem_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/process_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/rmdir_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/sendfile_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/signals_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/socket_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/strerror_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/systems_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/path_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/protobuf_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/recordio_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/result_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/some_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/strings_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/subcommand_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/svn_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/try_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/uri_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/uuid_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/variant_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/version_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:193: warning: source file 'tests/proc_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:193: but option 'subdir-objects' is disabled
autoreconf: Leaving directory `.'
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking target system type... x86_64-pc-linux-gnu
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking whether ln -s works... yes
checking for C++ compiler vendor... gnu
checking for a sed that does not truncate output... /bin/sed
checking for C++ compiler version... 5.4.0
checking for C++ compiler vendor... (cached) gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking whether make supports nested variables... yes
checking how to create a pax tar archive... gnutar
checking dependency style of gcc... gcc3
checking dependency style of g++... gcc3
checking whether to enable maintainer-specific portions of Makefiles... yes
checking for ar... ar
checking the archiver (ar) interface... ar
checking how to print strings... printf
checking for a sed that does not truncate output... (cached) /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /bin/dd
checking how to truncate binary pipes... /bin/dd bs=4096 count=1
checking for mt... no
checking if : is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
configure: creating ./config.lt
config.lt: creating libtool
checking whether to enable GC of unused sections... no
configure: Setting up CXXFLAGS for g++ version >= 4.8
checking whether C++ compiler accepts -fstack-protector-strong... yes
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=c++11... yes
checking if compiler needs -Werror to reject unknown flags... no
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking for PTHREAD_PRIO_INHERIT... yes
configure: Setting up build environment for x86_64 linux-gnu
checking for backtrace in -lunwind... no
checking for RAND_poll in -lcrypto... yes
checking openssl/ssl.h usability... yes
checking openssl/ssl.h presence... yes
checking for openssl/ssl.h... yes
checking for SSL_CTX_new in -lssl... yes
checking for main in -lgflags... no
checking for patch... patch
checking fts.h usability... yes
checking fts.h presence... yes
checking for fts.h... yes
checking for library containing fts_close... none required
checking apr_pools.h usability... yes
checking apr_pools.h presence... yes
checking for apr_pools.h... yes
checking for apr_initialize in -lapr-1... yes
checking for curl_global_init in -lcurl... yes
checking for javac... /usr/bin/javac
checking for java... /usr/bin/java
checking value of Java system property 'java.home'... /usr/lib/jvm/java-8-openjdk-amd64/jre
configure: using JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
checking whether or not we can build with JNI... yes
checking for mvn... /usr/bin/mvn
checking for javah... /usr/lib/jvm/java-8-openjdk-amd64/bin/javah
checking whether to enable launcher sealing... no
checking whether to enable the Seccomp isolator... no
checking for sasl_done in -lsasl2... yes
checking SASL CRAM-MD5 support... yes
checking svn_version.h usability... yes
checking svn_version.h presence... yes
checking for svn_version.h... yes
checking for svn_stringbuf_create_ensure in -lsvn_subr-1... yes
checking svn_delta.h usability... yes
checking svn_delta.h presence... yes
checking for svn_delta.h... yes
checking for svn_txdelta in -lsvn_delta-1... yes
checking whether to enable the XFS disk isolator... no
checking zlib.h usability... yes
checking zlib.h presence... yes
checking for zlib.h... yes
checking for deflate, gzread, gzwrite, inflate in -lz... yes
checking C++ standard library for undefined behaviour with selected optimization level... no
checking for python... /usr/bin/python
checking for python version... 2.7
checking for python platform... linux2
checking for python script directory... ${prefix}/lib/python2.7/dist-packages
checking for python extension module directory... ${exec_prefix}/lib/python2.7/dist-packages
checking for python2.7... (cached) /usr/bin/python
checking for a version of Python >= '2.1.0'... yes
checking for a version of Python >= '2.6'... yes
checking for the distutils Python package... yes
checking for Python include path... -I/usr/include/python2.7
checking for Python library path... -L/usr/lib -lpython2.7
checking for Python site-packages path... /usr/lib/python2.7/dist-packages
checking python extra libraries... -lpthread -ldl -lutil -lm
checking python extra linking flags... -Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions
checking consistency of all components of python development environment... yes
checking whether we can build usable Python eggs... cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
yes
checking for an old installation of the Mesos egg (before 0.20.0)... no
checking whether to enable new CLI... no
checking src/common/git_version.hpp presence... no
configure: generating src/common/git_version.hpp
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating mesos.pc
config.status: creating src/Makefile
config.status: creating 3rdparty/Makefile
config.status: creating 3rdparty/libprocess/Makefile
config.status: creating 3rdparty/libprocess/include/Makefile
config.status: creating 3rdparty/stout/Makefile
config.status: creating 3rdparty/stout/include/Makefile
config.status: creating 3rdparty/gmock_sources.cc
config.status: creating bin/mesos.sh
config.status: creating bin/mesos-agent.sh
config.status: creating bin/mesos-local.sh
config.status: creating bin/mesos-master.sh
config.status: creating bin/mesos-slave.sh
config.status: creating bin/mesos-tests.sh
config.status: creating bin/mesos-agent-flags.sh
config.status: creating bin/mesos-local-flags.sh
config.status: creating bin/mesos-master-flags.sh
config.status: creating bin/mesos-slave-flags.sh
config.status: creating bin/mesos-tests-flags.sh
config.status: creating bin/gdb-mesos-agent.sh
config.status: creating bin/gdb-mesos-local.sh
config.status: creating bin/gdb-mesos-master.sh
config.status: creating bin/gdb-mesos-slave.sh
config.status: creating bin/gdb-mesos-tests.sh
config.status: creating bin/lldb-mesos-agent.sh
config.status: creating bin/lldb-mesos-local.sh
config.status: creating bin/lldb-mesos-master.sh
config.status: creating bin/lldb-mesos-slave.sh
config.status: creating bin/lldb-mesos-tests.sh
config.status: creating bin/valgrind-mesos-agent.sh
config.status: creating bin/valgrind-mesos-local.sh
config.status: creating bin/valgrind-mesos-master.sh
config.status: creating bin/valgrind-mesos-slave.sh
config.status: creating bin/valgrind-mesos-tests.sh
config.status: creating src/deploy/mesos-daemon.sh
config.status: creating src/deploy/mesos-start-agents.sh
config.status: creating src/deploy/mesos-start-cluster.sh
config.status: creating src/deploy/mesos-start-masters.sh
config.status: creating src/deploy/mesos-start-slaves.sh
config.status: creating src/deploy/mesos-stop-agents.sh
config.status: creating src/deploy/mesos-stop-cluster.sh
config.status: creating src/deploy/mesos-stop-masters.sh
config.status: creating src/deploy/mesos-stop-slaves.sh
config.status: creating include/mesos/version.hpp
config.status: creating src/java/generated/org/apache/mesos/MesosNativeLibrary.java
config.status: creating src/examples/java/test-exception-framework
config.status: creating src/examples/java/test-executor
config.status: creating src/examples/java/test-framework
config.status: creating src/examples/java/test-multiple-executors-framework
config.status: creating src/examples/java/test-log
config.status: creating src/examples/java/v1-test-framework
config.status: creating src/java/mesos.pom
config.status: creating src/examples/python/test-executor
config.status: creating src/examples/python/test-framework
config.status: creating src/python/setup.py
config.status: creating src/python/cli/setup.py
config.status: creating src/python/interface/setup.py
config.status: creating src/python/native_common/ext_modules.py
config.status: creating src/python/executor/setup.py
config.status: creating src/python/native/setup.py
config.status: creating src/python/scheduler/setup.py
config.status: creating src/common/git_version.hpp
config.status: linking src/python/native_common/ext_modules.py to src/python/executor/ext_modules.py
config.status: linking src/python/native_common/ext_modules.py to src/python/scheduler/ext_modules.py
config.status: executing depfiles commands
config.status: executing libtool commands
configure: Build option summary:
CXX: g++
CXXFLAGS: -g1 -O0 -Wno-unused-local-typedefs -std=c++11
CPPFLAGS: -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0
LDFLAGS:
LIBS: -lz -lsvn_delta-1 -lsvn_subr-1 -lsasl2 -lcurl -lapr-1 -lrt
JAVA_TEST_LDFLAGS: -L/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server -R/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server -Wl,-ljvm
JAVA_JVM_LIBRARY: /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory '/tmp/SRC/build'
if test -d "mesos-1.10.0"; then find "mesos-1.10.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "mesos-1.10.0" || { sleep 5 && rm -rf "mesos-1.10.0"; }; else :; fi
test -d "mesos-1.10.0" || mkdir "mesos-1.10.0"
(cd 3rdparty && make top_distdir=../mesos-1.10.0 distdir=../mesos-1.10.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory '/tmp/SRC/build/3rdparty'
(cd stout && make top_distdir=../../mesos-1.10.0 distdir=../../mesos-1.10.0/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/tmp/SRC/build/3rdparty/stout'
(cd include && make top_distdir=../../../mesos-1.10.0 distdir=../../../mesos-1.10.0/3rdparty/stout/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory '/tmp/SRC/build/3rdparty/stout/include'
make[4]: Leaving directory '/tmp/SRC/build/3rdparty/stout/include'
make \
top_distdir="../../mesos-1.10.0" distdir="../../mesos-1.10.0/3rdparty/stout" \
dist-hook
make[4]: Entering directory '/tmp/SRC/build/3rdparty/stout'
cp -r ../../../3rdparty/stout/3rdparty ../../mesos-1.10.0/3rdparty/stout/
make[4]: Leaving directory '/tmp/SRC/build/3rdparty/stout'
make[3]: Leaving directory '/tmp/SRC/build/3rdparty/stout'
(cd libprocess && make top_distdir=../../mesos-1.10.0 distdir=../../mesos-1.10.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/tmp/SRC/build/3rdparty/libprocess'
(cd include && make top_distdir=../../../mesos-1.10.0 distdir=../../../mesos-1.10.0/3rdparty/libprocess/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory '/tmp/SRC/build/3rdparty/libprocess/include'
make[4]: Leaving directory '/tmp/SRC/build/3rdparty/libprocess/include'
make \
top_distdir="../../mesos-1.10.0" distdir="../../mesos-1.10.0/3rdparty/libprocess" \
dist-hook
make[4]: Entering directory '/tmp/SRC/build/3rdparty/libprocess'
cp -r ../../../3rdparty/libprocess/3rdparty ../../mesos-1.10.0/3rdparty/libprocess/
make[4]: Leaving directory '/tmp/SRC/build/3rdparty/libprocess'
make[3]: Leaving directory '/tmp/SRC/build/3rdparty/libprocess'
make[2]: Leaving directory '/tmp/SRC/build/3rdparty'
(cd src && make top_distdir=../mesos-1.10.0 distdir=../mesos-1.10.0/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory '/tmp/SRC/build/src'
../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3rdparty/csi-0.2.0 -I../3rdparty/csi-1.1.0 -I../3rdparty/protobuf-3.5.0/src --cpp_out=. ../../src/tests/common/http_tests.proto
/bin/bash: ../3rdparty/protobuf-3.5.0/src/protoc: No such file or directory
Makefile:15651: recipe for target 'tests/common/http_tests.pb.cc' failed
make[2]: *** [tests/common/http_tests.pb.cc] Error 127
make[2]: Leaving directory '/tmp/SRC/build/src'
Makefile:885: recipe for target 'distdir' failed
make[1]: *** [distdir] Error 1
make[1]: Leaving directory '/tmp/SRC/build'
Makefile:984: recipe for target 'dist' failed
make: *** [dist] Error 2
Untagged: mesos/mesos-build:ubuntu-16.04
Untagged: mesos/mesos-build@sha256:fa967cbcfb44f55708a3cbc87f245c6d29dd891464db558af56a03ee321526bb
Deleted: sha256:e895c0531b9a9a288fabe479a49f7059aed83645351ac99ec2ea2616822c9f97
Deleted: sha256:09119b0b314a69ba6ec6251f2e89f4199fe1e874c84f9abf07dcbd23dbc3f1c1
Deleted: sha256:562fe6af5a3883058be9c784a839392215ed4185a21d21f1d99df0d17f3ae6e7
Deleted: sha256:0dcdfbe322a4f332f73ac70905d557300ec6dae3bd19586758772c750c7b4a19
Deleted: sha256:c66652d605f01094e2db53d62505dbd524e076d5aa69b89d5e620003803eb149
Deleted: sha256:a2cf79bfb9593c05fd7142ddb49afef77ea4ad5d2464e841f09fe62ffee396e0
Deleted: sha256:f7a904214b390f39d98573882f631dc908df8b2b540cf04e1062f8182c1efffd
Deleted: sha256:ce1f6fcaa83dfce189d76e08f184085732eab4eeb2562d2399953958405c5bec
Deleted: sha256:cce92fda689ab9033f0b8db214bc63edd1ae3e05831a0f3a9418976d7dc7ccdd
Deleted: sha256:d22094bbd65447c59a42c580eaa3a44cee9cd855f00905f59409be21bcefc745
Deleted: sha256:b8976847450013f3eb5e9a81a5778f73ed7bef67e6393049712ef17102b4b7b7
Deleted: sha256:b8c891f0ffec910a12757d733b178e3f62d81dbbde2b31d3b754071c416108ed
Full log: https://builds.apache.org/job/Mesos-Reviewbot-Linux/9183/console
- Mesos Reviewbot
On April 28, 2020, 12:59 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated April 28, 2020, 12:59 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
> docs/task-state-reasons.md 10cb7e08d854ecfd16152fd370e4efe03b327347
> docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0
>
>
> Diff: https://reviews.apache.org/r/72410/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/
-----------------------------------------------------------
(Updated April 28, 2020, 12:59 a.m.)
Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
Bugs: MESOS-10115
https://issues.apache.org/jira/browse/MESOS-10115
Repository: mesos
Description
-------
Updated existing documentation for resource limits.
Diffs (updated)
-----
docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
docs/task-state-reasons.md 10cb7e08d854ecfd16152fd370e4efe03b327347
docs/upgrades.md 1e73e3d2626b7de93f5907bb52e008830f55e3a0
Diff: https://reviews.apache.org/r/72410/diff/2/
Changes: https://reviews.apache.org/r/72410/diff/1-2/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220407
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72408, 72409, 72410]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On April 21, 2020, 8:01 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated April 21, 2020, 8:01 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
>
>
> Diff: https://reviews.apache.org/r/72410/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Greg Mann <gr...@mesosphere.io>.
> On April 22, 2020, 2:02 p.m., Qian Zhang wrote:
> > docs/nested-container-and-task-group.md
> > Lines 74 (patched)
> > <https://reviews.apache.org/r/72410/diff/1/?file=2224550#file2224550line74>
> >
> > I see https://reviews.apache.org/r/72409 already has the content of this section, so can we avoid duplicating them here?
I think that this information belongs in both sections, which is why I included it here. To be honest, I'm not convinced that the 'nested-container-and-task-group.md' document is very useful as currently written, but I felt obligated to add this information here since it is relevant to task groups. I would suggest that we leave it as-is.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220423
-----------------------------------------------------------
On April 21, 2020, 8:01 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated April 21, 2020, 8:01 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
>
>
> Diff: https://reviews.apache.org/r/72410/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220423
-----------------------------------------------------------
docs/nested-container-and-task-group.md
Lines 74 (patched)
<https://reviews.apache.org/r/72410/#comment308809>
I see https://reviews.apache.org/r/72409 already has the content of this section, so can we avoid duplicating them here?
- Qian Zhang
On April 22, 2020, 4:01 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated April 22, 2020, 4:01 a.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
>
>
> Diff: https://reviews.apache.org/r/72410/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Tim Harper <ti...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220429
-----------------------------------------------------------
docs/nested-container-and-task-group.md
Line 65 (original), 65 (patched)
<https://reviews.apache.org/r/72410/#comment308816>
(see container.linux_info.share_cgroups field)
- Tim Harper
On April 21, 2020, 8:01 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated April 21, 2020, 8:01 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
>
>
> Diff: https://reviews.apache.org/r/72410/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72410: Updated existing documentation for resource
limits.
Posted by Tim Harper <ti...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72410/#review220430
-----------------------------------------------------------
Ship it!
- Tim Harper
On April 21, 2020, 8:01 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72410/
> -----------------------------------------------------------
>
> (Updated April 21, 2020, 8:01 p.m.)
>
>
> Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim Harper.
>
>
> Bugs: MESOS-10115
> https://issues.apache.org/jira/browse/MESOS-10115
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated existing documentation for resource limits.
>
>
> Diffs
> -----
>
> docs/nested-container-and-task-group.md 3325ff8e3a694ede82e22b24ab258742746c0bb7
> docs/scheduler-http-api.md 9831d527cc1f832a6fb0d0d330ebdc2a0b0f3774
>
>
> Diff: https://reviews.apache.org/r/72410/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>