You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/11/13 23:35:12 UTC

[GitHub] [incubator-pinot] snleee commented on pull request #6259: Broker time range pruning(#6189)

snleee commented on pull request #6259:
URL: https://github.com/apache/incubator-pinot/pull/6259#issuecomment-727085039


   @jtao15 is it true that `we need to store the segment name multiple times in different segments.`? My understanding was just to store a bit more extra information for each node (e.g. max value, pointers). 
   
   @Jackie-Jiang If storing segment name multiple times is the concern, we can optimize by using a hash map and use unique id instead of the segment name. I actually was also thinking of starting with the naive approach; however, @kishoreg and @noahprince22 had some concerns on the O(n) performance of the naive approach. 
   
   @kishoreg How do you think on this?
   
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org