[GitHub] [airflow] zhiyong-ong commented on a diff in pull request #27501: fix clearing child dag mapped tasks from parent dag

[GitBox <gi...@apache.org>]

zhiyong-ong commented on code in PR #27501:
URL: https://github.com/apache/airflow/pull/27501#discussion_r1024438098


##########
airflow/models/dag.py:
##########
@@ -1613,7 +1613,8 @@ def _get_task_instances(
 
         # Do we want full objects, or just the primary columns?
         if as_pk_tuple:
-            tis = session.query(TI.dag_id, TI.task_id, TI.run_id, TI.map_index)
+            # try number is needed here since its used to construct TaskInstanceKey
+            tis = session.query(TI.dag_id, TI.task_id, TI.run_id, TI._try_number, TI.map_index)

Review Comment:
   yes that's much neater. i'll do that instead. thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org