You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/11 06:06:57 UTC

[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #1815: [KYUUBI #1796] Destroy the process after the engine starts

wForget commented on a change in pull request #1815:
URL: https://github.com/apache/incubator-kyuubi/pull/1815#discussion_r804377631



##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -694,6 +694,14 @@ object KyuubiConf {
       .checkValue(_ > 0, "the maximum must be positive integer.")
       .createWithDefault(10)
 
+  val SESSION_ENGINE_STARTUP_WAIT_COMPLETION: ConfigEntry[Boolean] =
+    buildConf("session.engine.startup.waitCompletion")
+      .doc("Whether to wait for completion after engine starts." +

Review comment:
       > How about
   > 
   > > Note that only use it when the driver is not running locally, such as yarn-cluster mode; Otherwise, the engine will be killed.
   
   +1, I wil add it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org