You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/05/16 18:38:25 UTC
[GitHub] [lucene-solr] madrob opened a new pull request, #2655: SOLR-16143 SolrConfig ResourceProvider can miss updates from ZooKeeper
madrob opened a new pull request, #2655:
URL: https://github.com/apache/lucene-solr/pull/2655
(cherry picked from commit 3ed851fc84015f092271ccf8f93c1d20737804ca)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob merged pull request #2655: SOLR-16143 SolrConfig ResourceProvider can miss updates from ZooKeeper
Posted by GitBox <gi...@apache.org>.
madrob merged PR #2655:
URL: https://github.com/apache/lucene-solr/pull/2655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] madrob commented on a diff in pull request #2655: SOLR-16143 SolrConfig ResourceProvider can miss updates from ZooKeeper
Posted by GitBox <gi...@apache.org>.
madrob commented on code in PR #2655:
URL: https://github.com/apache/lucene-solr/pull/2655#discussion_r874178663
##########
solr/CHANGES.txt:
##########
@@ -48,6 +48,8 @@ Bug Fixes
* SOLR-16075: ShowFileHandler path parameter is now validated to be relative to instance conf dir in standalone mode (janhoy)
+* SOLR-16143: SolrConfig ResourceProvider can miss updates from ZooKeeper (Mike Drob)
Review Comment:
Updated this to be a little more natural language, will need to go back and update the 9x lines too to reflect the new verbiage once this is finalized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a diff in pull request #2655: SOLR-16143 SolrConfig ResourceProvider can miss updates from ZooKeeper
Posted by GitBox <gi...@apache.org>.
dsmiley commented on code in PR #2655:
URL: https://github.com/apache/lucene-solr/pull/2655#discussion_r874086689
##########
solr/CHANGES.txt:
##########
@@ -48,6 +48,8 @@ Bug Fixes
* SOLR-16075: ShowFileHandler path parameter is now validated to be relative to instance conf dir in standalone mode (janhoy)
+* SOLR-16143: SolrConfig ResourceProvider can miss updates from ZooKeeper (Mike Drob)
Review Comment:
As a general comment of CHANGES.txt entries, I'd prefer we word them in language we can all understand. I didn't know of this "ResourceProvider"; it's very internal. Instead, maybe try to say briefly what can go wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org