[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2005: Don't generate empty google.protobuf.rs

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2005:
URL: https://github.com/apache/arrow-rs/pull/2005#discussion_r916891037


##########
arrow-flight/build.rs:
##########
@@ -88,6 +88,13 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         file.write_all(buffer.as_bytes())?;
     }
 
+    // Prost currently generates an empty file, this was fixed but then reverted
+    // https://github.com/tokio-rs/prost/pull/639
+    let google_protobuf_rs = Path::new("src/sql/google.protobuf.rs");

Review Comment:
   We could do, but given it would be a code change to actually `include!()` it in the source code, I'm inclined to think it doesn't matter



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org