You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by kf...@collab.net on 2004/09/21 23:38:35 UTC

Possible bug in 'svn info'?

This is with a very recent trunk client, i.e., 1.2.0 (dev build).

Here's what happens when I run 'svn up' and then 'svn info' in a
working of Subversion trunk:

   $ svn up
   [...]
   Updated to revision 11063.
   $ svn info
   Path: .
   URL: http://svn.collab.net/repos/svn/trunk
   Repository UUID: 65390229-12b7-0310-b90b-f21a5aa7ec8e
   Revision: 11063
   Node Kind: directory
   Schedule: normal
   Last Changed Author: xsteve
   Last Changed Rev: 11062
   Last Changed Date: 2004-09-21 15:12:42 -0500 (Tue, 21 Sep 2004)
   Properties Last Updated: 2004-08-19 17:23:01 -0500 (Thu, 19 Aug 2004)
   $

What's the problem?

Well, when I updated I got r11063, which is what's in the Revision
field, okay.  But "Last Changed Rev" says r11062.  Strange.  Let's
look at the logs:

   ------------------------------------------------------------------------
   r11063 | karolszk | 2004-09-21 16:50:01 -0500 (Tue, 21 Sep 2004) | 4 lines
   
   Polish translation fix.
   
   * subversion/po/pl.po: fixed two typos
   
   ------------------------------------------------------------------------
   r11062 | xsteve | 2004-09-21 15:12:42 -0500 (Tue, 21 Sep 2004) | 6 lines
   
   * trunk/contrib/client-side/psvn/psvn.el:
     - svn-log-edit-insert-files-to-commit: new variable
     - (svn-log-edit-insert-files-to-commit): new function to insert the
       files to commit in the *log-edit* buffer
     - (svn-log-edit-remove-comment-lines): new function to remove the
       additional lines inserted by svn-log-edit-insert-files-to-commit
   ------------------------------------------------------------------------

Clearly, all the "Last Changed Foo" information is accurate for
r11062.  But why is r11062 considered the Last Changed Rev for "."?
Obviously, neither r11063 nor r11062 changed anything directly on ".".
They both affected only things in deep down subdirs of "."  I think
the Last Changed Foo for "." should simply be the Last Changed Foo of
whatever the most recently changed thing somewhere under "." is.  (And
if it's something else, I certainly don't see why it should be r11062
in this case, since that's no more linked to "." than r11063 is.)

The Book seems to agree.  At least, in this directory example
http://svnbook.red-bean.com/svnbook-1.0/svn-book.html#svn-ch-9-sect-1.2-re-info
it says:

   $ svn info vendors
   Path: trunk
   URL: http://svn.red-bean.com/repos/test/vendors
   Revision: 19
   Node Kind: directory
   Schedule: normal
   Last Changed Author: harry
   Last Changed Rev: 19
   Last Changed Date: 2003-01-16 23:21:19 -0600 (Thu, 16 Jan 2003)
   $

So here, the directory's rev matches its last-changed rev.  Why should
it not do so for "." when I run "svn info" in my working copy?

Have we got an off-by-one bug here, or am I just missing something?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Possible bug in 'svn info'?

Posted by kf...@collab.net.
"Max Bowsher" <ma...@ukf.net> writes:
> You're just missing something :-)
> 
> Specifically, that 11063 was a *branch* commit.
> Therefore, it didn't affect anything under trunk, hence the last
> changed revision of trunk is 11062.

Sigh.  Thanks, Max.  If I had run 'svn log -v', instead of just
looking at the human-written paths in the log message, I would have
realized this right away.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Possible bug in 'svn info'?

Posted by Max Bowsher <ma...@ukf.net>.
kfogel@collab.net wrote:
> This is with a very recent trunk client, i.e., 1.2.0 (dev build).
>
> Here's what happens when I run 'svn up' and then 'svn info' in a
> working of Subversion trunk:
>
>   $ svn up
>   [...]
>   Updated to revision 11063.
>   $ svn info
>   Path: .
>   URL: http://svn.collab.net/repos/svn/trunk
>   Repository UUID: 65390229-12b7-0310-b90b-f21a5aa7ec8e
>   Revision: 11063
>   Node Kind: directory
>   Schedule: normal
>   Last Changed Author: xsteve
>   Last Changed Rev: 11062
>   Last Changed Date: 2004-09-21 15:12:42 -0500 (Tue, 21 Sep 2004)
>   Properties Last Updated: 2004-08-19 17:23:01 -0500 (Thu, 19 Aug 2004)
>   $
>
> What's the problem?
>
> Well, when I updated I got r11063, which is what's in the Revision
> field, okay.  But "Last Changed Rev" says r11062.  Strange.  Let's
> look at the logs:
>
>   ------------------------------------------------------------------------
>   r11063 | karolszk | 2004-09-21 16:50:01 -0500 (Tue, 21 Sep 2004) | 4 
> lines
>
>   Polish translation fix.
>
>   * subversion/po/pl.po: fixed two typos
>
>   ------------------------------------------------------------------------
>   r11062 | xsteve | 2004-09-21 15:12:42 -0500 (Tue, 21 Sep 2004) | 6 lines
>
>   * trunk/contrib/client-side/psvn/psvn.el:
>     - svn-log-edit-insert-files-to-commit: new variable
>     - (svn-log-edit-insert-files-to-commit): new function to insert the
>       files to commit in the *log-edit* buffer
>     - (svn-log-edit-remove-comment-lines): new function to remove the
>       additional lines inserted by svn-log-edit-insert-files-to-commit
>   ------------------------------------------------------------------------
>
> Clearly, all the "Last Changed Foo" information is accurate for
> r11062.  But why is r11062 considered the Last Changed Rev for "."?
> Obviously, neither r11063 nor r11062 changed anything directly on ".".
> They both affected only things in deep down subdirs of "."  I think
> the Last Changed Foo for "." should simply be the Last Changed Foo of
> whatever the most recently changed thing somewhere under "." is.  (And
> if it's something else, I certainly don't see why it should be r11062
> in this case, since that's no more linked to "." than r11063 is.)
>
> The Book seems to agree.  At least, in this directory example
> http://svnbook.red-bean.com/svnbook-1.0/svn-book.html#svn-ch-9-sect-1.2-re-info
> it says:
>
>   $ svn info vendors
>   Path: trunk
>   URL: http://svn.red-bean.com/repos/test/vendors
>   Revision: 19
>   Node Kind: directory
>   Schedule: normal
>   Last Changed Author: harry
>   Last Changed Rev: 19
>   Last Changed Date: 2003-01-16 23:21:19 -0600 (Thu, 16 Jan 2003)
>   $
>
> So here, the directory's rev matches its last-changed rev.  Why should
> it not do so for "." when I run "svn info" in my working copy?
>
> Have we got an off-by-one bug here, or am I just missing something?

You're just missing something :-)

Specifically, that 11063 was a *branch* commit.
Therefore, it didn't affect anything under trunk, hence the last changed 
revision of trunk is 11062.

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org