You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/18 20:55:20 UTC
[jira] [Commented] (BEAM-548) Combine$PerKeyWithHotKeyFanout should
propagate Display Data
[ https://issues.apache.org/jira/browse/BEAM-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427132#comment-15427132 ]
ASF GitHub Bot commented on BEAM-548:
-------------------------------------
GitHub user ianzhou1 opened a pull request:
https://github.com/apache/incubator-beam/pull/847
[BEAM-548] Fixed Combine display data
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ianzhou1/incubator-beam CombinePerKeyWithHotKeyFanout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/847.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #847
----
commit 8018044d479cc66330e115e9ea8e533c817c0fd0
Author: Ian Zhou <ia...@google.com>
Date: 2016-08-18T20:50:52Z
Fixed Combine display data
----
> Combine$PerKeyWithHotKeyFanout should propagate Display Data
> ------------------------------------------------------------
>
> Key: BEAM-548
> URL: https://issues.apache.org/jira/browse/BEAM-548
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Ben Chambers
> Assignee: Ian Zhou
> Priority: Minor
>
> When using hot key combines, we produce two anonymous CombineFn's that wrap the original CombineFn. These currently suppress the display data of the delegate, instead showing up as "Combine$PerKeyWithHotKeyFanout$1".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)