You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/04/18 16:19:21 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request #4079: PIP-34 Key_Shared subscription core implementation.

codelipenghui opened a new pull request #4079: PIP-34 Key_Shared subscription core implementation.
URL: https://github.com/apache/pulsar/pull/4079
 
 
   ### Motivation
   
   This is a core implementation for  [PIP-34](https://github.com/apache/pulsar/wiki/PIP-34%3A-Add-new-subscribe-type-Key_Failover) and there is a task tracker [ISSUE-4077](https://github.com/apache/pulsar/issues/4077)  for this PIP
   
   ### Modifications
   
   - Add a new subscription type named Key_Shared
   - Add PersistentStickyKeyDispatcherMultipleConsumers to handle the message dispatch
   - Add a simple hash range based consumer selector
   
   ### Verifying this change
   
   Add new unit tests to verifying the hash range selector and Key_Shared mode message consume.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (yes)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (not documented)
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   
   [ISSUE-4077](https://github.com/apache/pulsar/issues/4077) will track the task of documentation for this PR.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services