You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/31 16:14:45 UTC
[GitHub] [doris] morningman opened a new pull request, #11378: [fix](planner) Fix an issue where outputSmap's size could grow exponentially
morningman opened a new pull request, #11378:
URL: https://github.com/apache/doris/pull/11378
# Proposed changes
Issue Number: close #xxx
## Problem Summary
For `ExprSubstitutionMap.composeAndReplace()`
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #11378: [fix](planner) Fix an issue where outputSmap's size could grow exponentially
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #11378:
URL: https://github.com/apache/doris/pull/11378#discussion_r935044662
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java:
##########
@@ -39,7 +39,7 @@
* See Expr.substitute() and related functions for details on the actual substitution.
*/
public final class ExprSubstitutionMap {
- private static final Logger LOG = LoggerFactory.getLogger(ExprSubstitutionMap.class);
+ private static final Logger LOG = LogManager.getLogger(SlotRef.class);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11378: [fix](planner) Fix an issue where outputSmap's size could grow exponentially
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11378:
URL: https://github.com/apache/doris/pull/11378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11378: [fix](planner) Fix an issue where outputSmap's size could grow exponentially
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11378:
URL: https://github.com/apache/doris/pull/11378#issuecomment-1202126311
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #11378: [fix](planner) Fix an issue where outputSmap's size could grow exponentially
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #11378:
URL: https://github.com/apache/doris/pull/11378#discussion_r934212563
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java:
##########
@@ -39,7 +39,7 @@
* See Expr.substitute() and related functions for details on the actual substitution.
*/
public final class ExprSubstitutionMap {
- private static final Logger LOG = LoggerFactory.getLogger(ExprSubstitutionMap.class);
+ private static final Logger LOG = LogManager.getLogger(SlotRef.class);
Review Comment:
```suggestion
private static final Logger LOG = LogManager.getLogger(ExprSubstitutionMap.class);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #11378: [fix](planner) Fix an issue where outputSmap's size could grow exponentially
Posted by GitBox <gi...@apache.org>.
morningman commented on code in PR #11378:
URL: https://github.com/apache/doris/pull/11378#discussion_r935044181
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java:
##########
@@ -39,7 +39,7 @@
* See Expr.substitute() and related functions for details on the actual substitution.
*/
public final class ExprSubstitutionMap {
- private static final Logger LOG = LoggerFactory.getLogger(ExprSubstitutionMap.class);
+ private static final Logger LOG = LogManager.getLogger(SlotRef.class);
Review Comment:
Currently, we all use log4j directly instead of slf4j.
Maybe we should change all of them later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on a diff in pull request #11378: [fix](planner) Fix an issue where outputSmap's size could grow exponentially
Posted by GitBox <gi...@apache.org>.
stalary commented on code in PR #11378:
URL: https://github.com/apache/doris/pull/11378#discussion_r935023712
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ExprSubstitutionMap.java:
##########
@@ -39,7 +39,7 @@
* See Expr.substitute() and related functions for details on the actual substitution.
*/
public final class ExprSubstitutionMap {
- private static final Logger LOG = LoggerFactory.getLogger(ExprSubstitutionMap.class);
+ private static final Logger LOG = LogManager.getLogger(SlotRef.class);
Review Comment:
What's the difference between LogManager and LoggerFactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org