You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2010/11/09 00:40:11 UTC
[jira] Created: (HBASE-3208) HLog.findMemstoresWithEditsOlderThan
needs to look for edits that are equal to too
HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too
----------------------------------------------------------------------------------
Key: HBASE-3208
URL: https://issues.apache.org/jira/browse/HBASE-3208
Project: HBase
Issue Type: Bug
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Priority: Blocker
Fix For: 0.90.0
Follow up to HBASE-3198, now that we are doing the right thing it seems that TestWALObserver is throwing NPEs. Digging in more, I figured that HLog.findMemstoresWithEditsOlderThan actually needs to be looking at edits that are equal or older rather than just older since logs with only 1 edit won't get any regions to flush.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3208) HLog.findMemstoresWithEditsOlderThan
needs to look for edits that are equal to too
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929839#action_12929839 ]
Jean-Daniel Cryans commented on HBASE-3208:
-------------------------------------------
Committed to trunk, thanks for the reviews guys!
> HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3208
> URL: https://issues.apache.org/jira/browse/HBASE-3208
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.90.0
>
>
> Follow up to HBASE-3198, now that we are doing the right thing it seems that TestWALObserver is throwing NPEs. Digging in more, I figured that HLog.findMemstoresWithEditsOlderThan actually needs to be looking at edits that are equal or older rather than just older since logs with only 1 edit won't get any regions to flush.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-3208) HLog.findMemstoresWithEditsOlderThan
needs to look for edits that are equal to too
Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Daniel Cryans resolved HBASE-3208.
---------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
> HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3208
> URL: https://issues.apache.org/jira/browse/HBASE-3208
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.90.0
>
>
> Follow up to HBASE-3198, now that we are doing the right thing it seems that TestWALObserver is throwing NPEs. Digging in more, I figured that HLog.findMemstoresWithEditsOlderThan actually needs to be looking at edits that are equal or older rather than just older since logs with only 1 edit won't get any regions to flush.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3208) HLog.findMemstoresWithEditsOlderThan
needs to look for edits that are equal to too
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929838#action_12929838 ]
HBase Review Board commented on HBASE-3208:
-------------------------------------------
Message from: "Jonathan Gray" <jg...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1188/#review1851
-----------------------------------------------------------
Ship it!
looks good to me
- Jonathan
> HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3208
> URL: https://issues.apache.org/jira/browse/HBASE-3208
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.90.0
>
>
> Follow up to HBASE-3198, now that we are doing the right thing it seems that TestWALObserver is throwing NPEs. Digging in more, I figured that HLog.findMemstoresWithEditsOlderThan actually needs to be looking at edits that are equal or older rather than just older since logs with only 1 edit won't get any regions to flush.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3208) HLog.findMemstoresWithEditsOlderThan
needs to look for edits that are equal to too
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929824#action_12929824 ]
HBase Review Board commented on HBASE-3208:
-------------------------------------------
Message from: "Jean-Daniel Cryans" <jd...@apache.org>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1188/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
This patch simply adds the "<=" in findMemstoresWithEditsOlderThan, renames it to findMemstoresWithEditsEqualOrOlderThan, and fixes the unit tests.
This addresses bug HBASE-3208.
http://issues.apache.org/jira/browse/HBASE-3208
Diffs
-----
/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 1032760
/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 1032760
Diff: http://review.cloudera.org/r/1188/diff
Testing
-------
Thanks,
Jean-Daniel
> HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3208
> URL: https://issues.apache.org/jira/browse/HBASE-3208
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.90.0
>
>
> Follow up to HBASE-3198, now that we are doing the right thing it seems that TestWALObserver is throwing NPEs. Digging in more, I figured that HLog.findMemstoresWithEditsOlderThan actually needs to be looking at edits that are equal or older rather than just older since logs with only 1 edit won't get any regions to flush.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-3208) HLog.findMemstoresWithEditsOlderThan
needs to look for edits that are equal to too
Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929837#action_12929837 ]
HBase Review Board commented on HBASE-3208:
-------------------------------------------
Message from: "Kannan Muthukkaruppan" <ka...@facebook.com>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1188/#review1850
-----------------------------------------------------------
Ship it!
Make sense. LGTM.
- Kannan
> HLog.findMemstoresWithEditsOlderThan needs to look for edits that are equal to too
> ----------------------------------------------------------------------------------
>
> Key: HBASE-3208
> URL: https://issues.apache.org/jira/browse/HBASE-3208
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Priority: Blocker
> Fix For: 0.90.0
>
>
> Follow up to HBASE-3198, now that we are doing the right thing it seems that TestWALObserver is throwing NPEs. Digging in more, I figured that HLog.findMemstoresWithEditsOlderThan actually needs to be looking at edits that are equal or older rather than just older since logs with only 1 edit won't get any regions to flush.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.