You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Jinmei Liao <ji...@pivotal.io> on 2016/02/19 17:51:18 UTC

Review Request 43768: GEODE-929: Do not use AvailablePort.getRandomAvailablePort in this test to avoid intermittent PortNotAvailable error.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43768/
-----------------------------------------------------------

Review request for geode.


Repository: geode


Description
-------

GEODE-929: Do not use AvailablePort.getRandomAvailablePort in this test to avoid intermittent PortNotAvailable error.


Diffs
-----

  gemfire-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java f175d985136cac6f1f4e02f0d60dc3f9d236f32b 
  gemfire-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtil.java 6e24398014e4174c82cce6214fa237edb0eb08c6 

Diff: https://reviews.apache.org/r/43768/diff/


Testing
-------

Security Integration Test


Thanks,

Jinmei Liao

Re: Review Request 43768: GEODE-929: Do not use AvailablePort.getRandomAvailablePort in this test to avoid intermittent PortNotAvailable error.

Posted by Kirk Lund <ki...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43768/#review119901
-----------------------------------------------------------


Ship it!




Ship It!

- Kirk Lund


On Feb. 19, 2016, 4:51 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43768/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 4:51 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-929: Do not use AvailablePort.getRandomAvailablePort in this test to avoid intermittent PortNotAvailable error.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java f175d985136cac6f1f4e02f0d60dc3f9d236f32b 
>   gemfire-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtil.java 6e24398014e4174c82cce6214fa237edb0eb08c6 
> 
> Diff: https://reviews.apache.org/r/43768/diff/
> 
> 
> Testing
> -------
> 
> Security Integration Test
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 43768: GEODE-929: Do not use AvailablePort.getRandomAvailablePort in this test to avoid intermittent PortNotAvailable error.

Posted by Bruce Schuchardt <bs...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43768/#review120626
-----------------------------------------------------------


Ship it!




Ship It!

- Bruce Schuchardt


On Feb. 19, 2016, 4:51 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43768/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 4:51 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-929: Do not use AvailablePort.getRandomAvailablePort in this test to avoid intermittent PortNotAvailable error.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java f175d985136cac6f1f4e02f0d60dc3f9d236f32b 
>   gemfire-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtil.java 6e24398014e4174c82cce6214fa237edb0eb08c6 
> 
> Diff: https://reviews.apache.org/r/43768/diff/
> 
> 
> Testing
> -------
> 
> Security Integration Test
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Re: Review Request 43768: GEODE-929: Do not use AvailablePort.getRandomAvailablePort in this test to avoid intermittent PortNotAvailable error.

Posted by Jianxia Chen <jc...@pivotal.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43768/#review119902
-----------------------------------------------------------




gemfire-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java (line 89)
<https://reviews.apache.org/r/43768/#comment181295>

    SecurityTestUtil.getLocatorPort itself is still calling AvailablePort.getRandomAvailablePort. Will this cause intermittent PortNotAvailable error?



gemfire-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtil.java (line 344)
<https://reviews.apache.org/r/43768/#comment181296>

    Why the port is set to a fixed number 0?


- Jianxia Chen


On Feb. 19, 2016, 4:51 p.m., Jinmei Liao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43768/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2016, 4:51 p.m.)
> 
> 
> Review request for geode.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-929: Do not use AvailablePort.getRandomAvailablePort in this test to avoid intermittent PortNotAvailable error.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/test/java/com/gemstone/gemfire/security/ClientMultiUserAuthzDUnitTest.java f175d985136cac6f1f4e02f0d60dc3f9d236f32b 
>   gemfire-core/src/test/java/com/gemstone/gemfire/security/SecurityTestUtil.java 6e24398014e4174c82cce6214fa237edb0eb08c6 
> 
> Diff: https://reviews.apache.org/r/43768/diff/
> 
> 
> Testing
> -------
> 
> Security Integration Test
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>