[GitHub] kishoreg commented on a change in pull request #3528: Adding support for bloom filter

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #3528: Adding support for bloom filter
URL: https://github.com/apache/incubator-pinot/pull/3528#discussion_r235212944
 
 

 ##########
 File path: pinot-common/src/main/java/com/linkedin/pinot/common/config/IndexingConfig.java
 ##########
 @@ -113,6 +116,15 @@ public void setSortedColumn(List<String> sortedColumn) {
     _sortedColumn = sortedColumn;
   }
 
+  
+  public List<String> getBloomFilterColumns() {
 
 Review comment:
   Did not want to overload the config. Its possible we need bloom filter without inverted index and vice versa. Also sorted index does not need an entry in invertedIndexColumns but we might need bloom filter for a sorted column

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org