You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@libcloud.apache.org by Jaume Devesa <de...@gmail.com> on 2013/01/26 17:22:45 UTC
[dev] Local storage driver does not pass tests with python 2.5
Updating the current 'trunk' branch from github, the local storage driver
does not pass the 'tox' tests using python 2.5 environment.
The reason is it uses the os.path.relpath(...) function (
https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/local.py#L218),
and this function was not implemented yet in python 2.5:
http://docs.python.org/release/2.5.4/lib/module-os.path.html
I didn't open a Jira issue because it is a not-yet released feature, and I
didn't want to make noise there...
Re: [dev] Local storage driver does not pass tests with python 2.5
Posted by Jaume Devesa <de...@gmail.com>.
Great, it runs without problems now.
On 27 January 2013 01:34, Tomaz Muraus <to...@apache.org> wrote:
> You are right. I forgot that buildbot doesn't actually use tox to run tests
> with Python 2.5 (
>
> http://ci.apache.org/builders/libcloud-trunk-py25/builds/591/steps/compile/logs/stdio
> ).
>
> I've committed a change to trunk which should fix the relpath issue in
> Python 2.5 (http://svn.apache.org/viewvc?view=revision&revision=1439005).
>
> Let us know if this fixes the problem for you and if there are any other
> Python 2.5 related issues in the local_storage driver.
>
> Thanks
>
> On Sat, Jan 26, 2013 at 11:10 AM, Jaume Devesa <devesa.lists@gmail.com
> >wrote:
>
> > Let me think... because there is something I don't understand here or I
> am
> > doing wrong, then. I am sure I have pulled the last github commit
> > (ee3cf259478f4550ccd26a0e3a5819b9d37314d1), but the *tox *command fails
> in
> > my python2.5 environment
> >
> > I never have used tox before, but IMHO it actually installs *lockfile* in
> > python 2.5 according with the *tox.ini* file:
> > https://github.com/apache/libcloud/blob/trunk/tox.ini#L12
> >
> > If I comment that line and run the tox command again, then it skips the
> > 'test_local.py' and runs properly.
> >
> >
> > On 26 January 2013 19:02, Tomaz Muraus <to...@apache.org> wrote:
> >
> > > There is actually another issues which prevents local_storage tests
> from
> > > running with Python 2.5 and that is "lockfile" dependency not being
> > > available for 2.5.
> > >
> > > Because of this we currently just skip tests under 2.5 and other
> versions
> > > where lockfile dependency is not available -
> > >
> > >
> >
> https://github.com/apache/libcloud/blob/trunk/libcloud/test/storage/test_local.py#L36
> > >
> > > On Sat, Jan 26, 2013 at 8:22 AM, Jaume Devesa <devesa.lists@gmail.com
> > > >wrote:
> > >
> > > > Updating the current 'trunk' branch from github, the local storage
> > driver
> > > > does not pass the 'tox' tests using python 2.5 environment.
> > > >
> > > > The reason is it uses the os.path.relpath(...) function (
> > > >
> > > >
> > >
> >
> https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/local.py#L218
> > > > ),
> > > > and this function was not implemented yet in python 2.5:
> > > > http://docs.python.org/release/2.5.4/lib/module-os.path.html
> > > >
> > > > I didn't open a Jira issue because it is a not-yet released feature,
> > and
> > > I
> > > > didn't want to make noise there...
> > > >
> > >
> >
>
Re: [dev] Local storage driver does not pass tests with python 2.5
Posted by Tomaz Muraus <to...@apache.org>.
You are right. I forgot that buildbot doesn't actually use tox to run tests
with Python 2.5 (
http://ci.apache.org/builders/libcloud-trunk-py25/builds/591/steps/compile/logs/stdio
).
I've committed a change to trunk which should fix the relpath issue in
Python 2.5 (http://svn.apache.org/viewvc?view=revision&revision=1439005).
Let us know if this fixes the problem for you and if there are any other
Python 2.5 related issues in the local_storage driver.
Thanks
On Sat, Jan 26, 2013 at 11:10 AM, Jaume Devesa <de...@gmail.com>wrote:
> Let me think... because there is something I don't understand here or I am
> doing wrong, then. I am sure I have pulled the last github commit
> (ee3cf259478f4550ccd26a0e3a5819b9d37314d1), but the *tox *command fails in
> my python2.5 environment
>
> I never have used tox before, but IMHO it actually installs *lockfile* in
> python 2.5 according with the *tox.ini* file:
> https://github.com/apache/libcloud/blob/trunk/tox.ini#L12
>
> If I comment that line and run the tox command again, then it skips the
> 'test_local.py' and runs properly.
>
>
> On 26 January 2013 19:02, Tomaz Muraus <to...@apache.org> wrote:
>
> > There is actually another issues which prevents local_storage tests from
> > running with Python 2.5 and that is "lockfile" dependency not being
> > available for 2.5.
> >
> > Because of this we currently just skip tests under 2.5 and other versions
> > where lockfile dependency is not available -
> >
> >
> https://github.com/apache/libcloud/blob/trunk/libcloud/test/storage/test_local.py#L36
> >
> > On Sat, Jan 26, 2013 at 8:22 AM, Jaume Devesa <devesa.lists@gmail.com
> > >wrote:
> >
> > > Updating the current 'trunk' branch from github, the local storage
> driver
> > > does not pass the 'tox' tests using python 2.5 environment.
> > >
> > > The reason is it uses the os.path.relpath(...) function (
> > >
> > >
> >
> https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/local.py#L218
> > > ),
> > > and this function was not implemented yet in python 2.5:
> > > http://docs.python.org/release/2.5.4/lib/module-os.path.html
> > >
> > > I didn't open a Jira issue because it is a not-yet released feature,
> and
> > I
> > > didn't want to make noise there...
> > >
> >
>
Re: [dev] Local storage driver does not pass tests with python 2.5
Posted by Jaume Devesa <de...@gmail.com>.
Let me think... because there is something I don't understand here or I am
doing wrong, then. I am sure I have pulled the last github commit
(ee3cf259478f4550ccd26a0e3a5819b9d37314d1), but the *tox *command fails in
my python2.5 environment
I never have used tox before, but IMHO it actually installs *lockfile* in
python 2.5 according with the *tox.ini* file:
https://github.com/apache/libcloud/blob/trunk/tox.ini#L12
If I comment that line and run the tox command again, then it skips the
'test_local.py' and runs properly.
On 26 January 2013 19:02, Tomaz Muraus <to...@apache.org> wrote:
> There is actually another issues which prevents local_storage tests from
> running with Python 2.5 and that is "lockfile" dependency not being
> available for 2.5.
>
> Because of this we currently just skip tests under 2.5 and other versions
> where lockfile dependency is not available -
>
> https://github.com/apache/libcloud/blob/trunk/libcloud/test/storage/test_local.py#L36
>
> On Sat, Jan 26, 2013 at 8:22 AM, Jaume Devesa <devesa.lists@gmail.com
> >wrote:
>
> > Updating the current 'trunk' branch from github, the local storage driver
> > does not pass the 'tox' tests using python 2.5 environment.
> >
> > The reason is it uses the os.path.relpath(...) function (
> >
> >
> https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/local.py#L218
> > ),
> > and this function was not implemented yet in python 2.5:
> > http://docs.python.org/release/2.5.4/lib/module-os.path.html
> >
> > I didn't open a Jira issue because it is a not-yet released feature, and
> I
> > didn't want to make noise there...
> >
>
Re: [dev] Local storage driver does not pass tests with python 2.5
Posted by Tomaz Muraus <to...@apache.org>.
There is actually another issues which prevents local_storage tests from
running with Python 2.5 and that is "lockfile" dependency not being
available for 2.5.
Because of this we currently just skip tests under 2.5 and other versions
where lockfile dependency is not available -
https://github.com/apache/libcloud/blob/trunk/libcloud/test/storage/test_local.py#L36
On Sat, Jan 26, 2013 at 8:22 AM, Jaume Devesa <de...@gmail.com>wrote:
> Updating the current 'trunk' branch from github, the local storage driver
> does not pass the 'tox' tests using python 2.5 environment.
>
> The reason is it uses the os.path.relpath(...) function (
>
> https://github.com/apache/libcloud/blob/trunk/libcloud/storage/drivers/local.py#L218
> ),
> and this function was not implemented yet in python 2.5:
> http://docs.python.org/release/2.5.4/lib/module-os.path.html
>
> I didn't open a Jira issue because it is a not-yet released feature, and I
> didn't want to make noise there...
>