You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pavanb018 <gi...@git.apache.org> on 2016/01/07 06:20:12 UTC
[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...
GitHub user pavanb018 opened a pull request:
https://github.com/apache/cloudstack/pull/1315
Automation for CLOUDSTACK-9214 , detect wrong GW or NM
Automation for CLOUDSTACK-9214
This script automates the validation of network address or broadcast address given for gateway or wrong netmask is given during network creation,
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pavanb018/cloudstack master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1315
----
commit 792e49366b5ee1f7ce86c75f6d1f6cf61dd37bf8
Author: pavanb018 <pa...@gmail.com>
Date: 2016-01-07T05:17:28Z
Automation for CLOUDSTACK-9214 , detect wrong GW or NM
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1315#issuecomment-170338260
LGTM too, thanks @shwetaag
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1315#issuecomment-169660744
@shwetaag a LGTM without justification of what verification is done won't be accepted. Please specify what you did to come to this conclusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1315#issuecomment-169611566
looks good on first sight, buiding an env to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1315#issuecomment-169628989
nosetests --with-marvin --marvin-config=/data/shared/marvin/mct-zone1-kvm1-kvm2-zwps-sg.cfg -s -a tags=advanced,required_hardware=false /data/git/cs1/cloudstack/test/integration/component/test_invalid_gw_nm.py
==== Marvin Init Started ====
=== Marvin Parse Config Successful ===
=== Marvin Setting TestData Successful===
==== Log Folder Path: /tmp//MarvinLogs//Jan_07_2016_10_55_08_UKK65V. All logs will be available here ====
=== Marvin Init Logging Successful===
==== Marvin Init Successful ====
=== TestName: test_isolated_nw_invalid_gw | Status : SUCCESS ===
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...
Posted by shwetaag <gi...@git.apache.org>.
Github user shwetaag commented on the pull request:
https://github.com/apache/cloudstack/pull/1315#issuecomment-169647027
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Automation for CLOUDSTACK-9214 , detect w...
Posted by shwetaag <gi...@git.apache.org>.
Github user shwetaag commented on the pull request:
https://github.com/apache/cloudstack/pull/1315#issuecomment-169947496
@DaanHoogland I did the code review by code walk through and the code looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---