You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/02/08 13:59:55 UTC

[GitHub] Jason918 opened a new pull request #751: [Rip 7] Multiple Directories Storage Support[Rip #7] Multiple Directories Storage Support

Jason918 opened a new pull request #751: [Rip 7] Multiple Directories Storage Support[Rip #7] Multiple Directories Storage Support
URL: https://github.com/apache/rocketmq/pull/751
 
 
   ## What is the purpose of the change
   
   Add Multiple Directories Storage Support for commit log. 
   Detailed info is in [RIP-7 ](https://github.com/apache/rocketmq/wiki/RIP-7-Multiple-Directories-Storage-Support)
   
   ## Brief changelog
   
   add 3 parameters in message store config:
   
   1. multiCommitLogPathEnable
   set true is you want to use multi-path support for commit log.
   default is false;
   
   2. commitLogStorePaths: 
   Value Format: path1:path2:path3
   eg: /data1:/data2:/data3
   Commit log file segments will be created in these paths in a round-robin manner. 
   This config can be updated online in case of some hardware mulfunction.
   Normally, different pathes should be on different disks.
   
   3. readOnlyCommitLogStorePaths
   Value format is the same as commitLogStorePaths.
   This parameter is used when you want to stop writing commit log data to a path, but there is still some old commlog file that are not expired, and you still need read these data.
   NOTICE: 
   a) This config can not be updated online 
   b) If a path appeared in commitLogStorePaths and readOnlyCommitLogStorePaths at the same time, it does not mean that this path is readonly, and commit log file will still be created in this path.
   
   ## Verifying this change
   
   add these paramters in the config file:
   
   multiCommitLogPathEnable=true
   commitLogStorePaths=path1:path2:path3
       
   
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services